Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relay Mutations getting linted as React Components #291

Closed
joshthecoder opened this issue Nov 5, 2015 · 6 comments
Closed

Relay Mutations getting linted as React Components #291

joshthecoder opened this issue Nov 5, 2015 · 6 comments

Comments

@joshthecoder
Copy link

Seeing lint errors mainly for prop-types and sort-comp rules
for classes that extend Relay.Mutation.

Started happening with 3.7 release.

@tylermcginnis
Copy link

I'm getting errors on both of those as well but without extending Relay.Mutation, just normally with createClass.

@yannickcr
Copy link
Member

Can you give me a code sample that trigger invalid lint errors ?

@tylermcginnis
Copy link

I don't want to highjack this issue so I'll open a different issue.

@joshthecoder
Copy link
Author

This snippet seems to trigger the issue:

import { Mutation } from 'react-relay';

export default class MyMutation extends Mutation {
  static fragments = {
  }

  getVariables() {
    this.props.foo;  // This seems to trigger the issue.
  }
}

@taion
Copy link
Contributor

taion commented Nov 7, 2015

Possibly related to #295.

@taion
Copy link
Contributor

taion commented Nov 7, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants