Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consecutive capital letters in jsx-pascal-case #328

Closed
lencioni opened this issue Nov 23, 2015 · 2 comments · Fixed by #333
Closed

Consecutive capital letters in jsx-pascal-case #328

lencioni opened this issue Nov 23, 2015 · 2 comments · Fixed by #333
Labels
enhancement rule

Comments

@lencioni
Copy link
Collaborator

I like the new pascal case rule, but I've run into a couple of cases where I have consecutive capital letters and am wondering if perhaps this should be allowed. For instance:

<CSSTransitionGroup>
@yannickcr
Copy link
Member

I think this should also be allowed by the rule.

@lencioni
Copy link
Collaborator Author

Great! I'll submit a PR shortly.

lencioni added a commit to lencioni/eslint-plugin-react that referenced this issue Nov 24, 2015
@lencioni
Allow consecutive uppercase letters in jsx-pascal-case
c5b67d4 
I've run into a couple of cases where I have consecutive capital letters
in React components (e.g. <CSSTransitionGroup>), and jsx-pascal-case is
complaining about them. This commit fixes this problem by allowing
consecutive uppercase letters.

Fixes jsx-eslint#328
@lencioni lencioni mentioned this issue Nov 24, 2015
Merged
yannickcr added a commit that referenced this issue Nov 25, 2015
@yannickcr
Merge pull request #333 from lencioni/pascal-caps
1bd8c89 
Allow consecutive uppercase letters in jsx-pascal-case (fixes #328)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement rule
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow consecutive uppercase letters in jsx-pascal-case lencioni/eslint-plugin-react
2 participants
@yannickcr @lencioni