Fix the newline with object literals bug

[fatfisz]

From comment #857 (comment):

Found another bug:

<App foo={
{ bar: true, baz: true }
} />;

This would get 2 errors using the default settings: There should be no space after '{' and There should be no space before '}'.

This is because conditions for the object literal spacing were written so that the second one was never reached:

          if (sourceCode.isSpaceBetweenTokens(first, second)) {
            reportNoBeginningSpace(node, first);
          } else if (!config.allowMultiline && isMultiline(first, second)) {
            reportNoBeginningNewline(node, first, config);
          }

If the first condition fails, isMultiline will return false - there is no newline.

Will fix this and add appropriate tests.

[ljharb]

can we keep this test case as well?

[fatfisz]

This test is identical with the one just below it, so I suggest it stays removed.

[fatfisz]

(or is there any reason for the duplicated test?)

[ljharb]

good call, i didn't realize it was duplicated

[ljharb]

Now that we support node 4+, all these can just be parserOptions (only the new examples; we'll change all the rest in their own commit)

[fatfisz]

I'm not sure if having only a part the code conform to the new convention is a good idea, especially since this convention can be applied automatically. How about I make a separate PR which replaces all occurences of parserOptions: parserOptions with parserOptions everywhere?

[ljharb]

Sure, that's fine, I suppose.

[fatfisz]

I've rebased this. There's only the unresolved problem of the duplicate test left.