Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unnecessary schema from require-render-return #2341

Closed
wants to merge 1 commit into from
Closed

fix: remove unnecessary schema from require-render-return #2341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rules/require-render-return.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ module.exports = {
recommended: true,
url: docsUrl('require-render-return')
},
schema: [{}]
schema: []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like it'd be a breaking change, in case someone had already been providing an empty object.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it technically would be breaking in the strictest sense.
Though reviewing the history, this has been an empty object for 3 years, so I doubt there's some legacy config people have left over.

The problem is that this schema value doesn't just allow an empty object, it allows literally value.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes - i agree that's a problem, however, that means that removing this would cause eslint to crash on a config that was previously working :-/

},

create: Components.detect((context, components, utils) => {
Expand Down