Add new rule: no-comment-textnodes #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about false positives where the literal JS comment text is what's desired? |
|
@ljharb – They have two choices. Either disable the rule, or do: <div>{'// Not a comment'}</div>I personally think that's acceptable. This strikes me as a particularly rare edge case. |
|
@benvinegar want to add documentation for the rule, and include that info in it explicitly? :-D |
|
@ljharb – Updated with documentation. |
|
Seems to be a useful rule. Merged, thanks! |
|
a bite late, but: shouldn't the name of the rule be prefixed with |
|
I agree that this rule should have been prefixed with jsx-. |
|
No reason we couldn't change that as part of the next major bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our team has run into issues where people mistakenly commit comments as text nodes, and they have managed to get through code review and appeared (embarrassingly) in our UI. I threw together this rule to try and catch such occasions, and thought it might be useful to other users of this ESLint plugin.
Feedback, comments greatly appreciated.