Integrate jsx-ast-utils #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were the use cases I could locate for now.
beefancohen
changed the title
| @@ -5,6 +5,8 @@ | |||
| */ | |||
| 'use strict'; | |||
|
|
|||
| var propName = require('jsx-ast-utils').propName; | |||
There was a problem hiding this comment.
it'd be nice if we could require via path, ie, var propName = require('jsx-ast-utils/propName') rather than having to pull everything in and grab one property - but obv this is not a blocker :-)
There was a problem hiding this comment.
ah yes ill export from root directory too 😄
|
Awesome, love the code sharing |
|
This is really great! LGTM. if it is good to merge for you too I think we can merge it. |
|
Good for me - will try and continually send PR's as we flesh out |
|
Merged. Thank you very much :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in evcohen/eslint-plugin-jsx-a11y#54 we can integrate the jsx-ast-utils package here for better code reuse across these packages.
We can start adding API functions to fit use cases for this project as well to
jsx-ast-utilsin the next few iterations (i.e. styling and spacing functions)