Skip to content

Commit

Permalink
Bump to v3.0.0
Browse files Browse the repository at this point in the history
  • Loading branch information
yannickl committed Sep 25, 2018
1 parent 2aae2b6 commit c380f49
Show file tree
Hide file tree
Showing 8 changed files with 24 additions and 18 deletions.
2 changes: 1 addition & 1 deletion .swift-version
@@ -1 +1 @@
4.0
4.2
4 changes: 2 additions & 2 deletions .travis.yml
@@ -1,7 +1,7 @@
language: objective-c
osx_image: xcode9
osx_image: xcode10
script:
- cd Examples
- xcodebuild -version
- xcodebuild -project ReactionsExample.xcodeproj -scheme ReactionsTests -sdk iphonesimulator -destination "platform=iOS Simulator,name=iPhone 6" -configuration Release ONLY_ACTIVE_ARCH=YES -enableCodeCoverage YES test
- xcodebuild -project ReactionsExample.xcodeproj -scheme ReactionsTests -sdk iphonesimulator -destination "platform=iOS Simulator,name=iPhone 8" -configuration Release ONLY_ACTIVE_ARCH=YES -enableCodeCoverage YES test
- bash <(curl -s https://codecov.io/bash) -cF ios
2 changes: 1 addition & 1 deletion Examples/Reactions/Info.plist
Expand Up @@ -15,7 +15,7 @@
<key>CFBundlePackageType</key>
<string>FMWK</string>
<key>CFBundleShortVersionString</key>
<string>2.1.0</string>
<string>3.0.0</string>
<key>CFBundleVersion</key>
<string>$(CURRENT_PROJECT_VERSION)</string>
<key>NSPrincipalClass</key>
Expand Down
4 changes: 2 additions & 2 deletions Examples/ReactionsExample.xcodeproj/project.pbxproj
Expand Up @@ -693,7 +693,7 @@
PRODUCT_BUNDLE_IDENTIFIER = com.yannickloriot.ReactionsTests;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
SWIFT_VERSION = 4.0;
SWIFT_VERSION = 4.2;
TEST_HOST = "$(BUILT_PRODUCTS_DIR)/ReactionsExample.app/ReactionsExample";
};
name = Debug;
Expand All @@ -709,7 +709,7 @@
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = com.yannickloriot.ReactionsTests;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_VERSION = 4.0;
SWIFT_VERSION = 4.2;
TEST_HOST = "$(BUILT_PRODUCTS_DIR)/ReactionsExample.app/ReactionsExample";
};
name = Release;
Expand Down
2 changes: 1 addition & 1 deletion Examples/ReactionsExample/Info.plist
Expand Up @@ -15,7 +15,7 @@
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleShortVersionString</key>
<string>2.1.0</string>
<string>3.0.0</string>
<key>CFBundleVersion</key>
<string>1</string>
<key>LSRequiresIPhoneOS</key>
Expand Down
8 changes: 4 additions & 4 deletions README.md
Expand Up @@ -26,7 +26,7 @@

- iOS 8.0+
- Xcode 9.0+
- Swift 4.0+
- Swift 4.2+

## Usage

Expand Down Expand Up @@ -167,7 +167,7 @@ source 'https://github.com/CocoaPods/Specs.git'
platform :ios, '8.0'

use_frameworks!
pod 'Reactions', '~> 2.1.0'
pod 'Reactions', '~> 3.0.0'
```

Install into your project:
Expand Down Expand Up @@ -198,7 +198,7 @@ $ brew install carthage
To integrate `Reactions` into your Xcode project using Carthage, specify it in your `Cartfile` file:

```ogdl
github "yannickl/Reactions" >= 2.1.0
github "yannickl/Reactions" >= 3.0.0
```

#### Swift Package Manager
Expand All @@ -211,7 +211,7 @@ let package = Package(
name: "YOUR_PROJECT_NAME",
targets: [],
dependencies: [
.Package(url: "https://github.com/yannickl/Reactions.git", versions: "2.1.0" ..< Version.max)
.Package(url: "https://github.com/yannickl/Reactions.git", versions: "3.0.0" ..< Version.max)
]
)
```
Expand Down
2 changes: 1 addition & 1 deletion Reactions.podspec
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'Reactions'
s.version = '2.1.0'
s.version = '3.0.0'
s.license = 'MIT'
s.summary = 'Fully customizable Facebook reactions control'
s.homepage = 'https://github.com/yannickl/Reactions'
Expand Down
18 changes: 12 additions & 6 deletions Tests/ReactionButtonTests.swift
Expand Up @@ -141,10 +141,13 @@ class ReactionButtonTests: XCTestCase {

func testLongPressButtonWithSelector() {
class PressBeganGesture: UILongPressGestureRecognizer {
var currentState: UIGestureRecognizerState = .began
var currentState: UIGestureRecognizer.State = .began

override var state: UIGestureRecognizerState {
return currentState
override var state: UIGestureRecognizer.State {
get {
return currentState
}
set {}
}
}

Expand Down Expand Up @@ -178,10 +181,13 @@ class ReactionButtonTests: XCTestCase {

func testLongPressReactionSelector() {
class PressBeganGesture: UILongPressGestureRecognizer {
var currentState: UIGestureRecognizerState = .began
var currentState: UIGestureRecognizer.State = .began

override var state: UIGestureRecognizerState {
return currentState
override var state: UIGestureRecognizer.State {
get {
return currentState
}
set {}
}

override func location(in view: UIView?) -> CGPoint {
Expand Down

0 comments on commit c380f49

Please sign in to comment.