Adds info prints, SC3 logs backups, db exports, specific SC3 install … #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannikbehr
reviewed
May 15, 2017
misc/event.py
Outdated
| maxnumber=10, | ||
| catalog=None): | ||
|
|
||
| from obspy import UTCDateTime |
There was a problem hiding this comment.
Is there a particular reason to have the imports inside the function? I don't want to impose pep8 on you but I think their guidelines on imports and indenting make a lot of sense https://www.python.org/dev/peps/pep-0008/#imports
yannikbehr
reviewed
May 15, 2017
misc/event.py
Outdated
| if catalog: | ||
| cat = client.get_events(limit=maxnumber, orderby="magnitude",starttime=starttime, endtime=endtime, minmagnitude=minmag, maxmagnitude=maxmag, catalog="ISC") | ||
| else: | ||
| cat = client.get_events(limit=maxnumber, orderby="magnitude",starttime=starttime, endtime=endtime, minmagnitude=minmag, maxmagnitude=maxmag) |
There was a problem hiding this comment.
What's the reason to hardwire the request to the ISC catalog?
yannikbehr
reviewed
May 15, 2017
playback.sh
Outdated
| @@ -3,14 +3,15 @@ | |||
| PLAYBACKROOT="$( dirname "$( readlink -f "$0")")/" | |||
| MAKEMSEEDPLAYBACK="${PLAYBACKROOT}make-mseed-playback.py" | |||
| RUNPLAYBACK="${PLAYBACKROOT}playback.py" | |||
| PLAYBACKDATA="${PLAYBACKROOT}data" | |||
There was a problem hiding this comment.
This requires someone to remember the trailing '/'. I think two '/' are not a problem but a missing one is.
yannikbehr
reviewed
May 15, 2017
playback.sh
Outdated
| MSFILE=`ls "${PBDIR}"/*sorted-mseed` | ||
| EVNTFILE=`ls "${PBDIR}"/*_events.xml` | ||
| "$RUNPLAYBACK" "${PBDIR}/${PBDB}" "${MSFILE}" "${DELAYS}" -c "${CONFIGDIR}" -m ${MODE} -e "${EVNTFILE}" | ||
|
|
||
| "$RUNPLAYBACK" "${PBDIR}/${PBDB}" "${MSFILE}" "${DELAYS}" -c "${CONFIGDIR}" -m ${MODE} #-e "${EVNTFILE}" |
There was a problem hiding this comment.
What is the rational to take out the eventfile?
There was a problem hiding this comment.
I was trying something and forgot about it, sorry...
yannikbehr
reviewed
May 15, 2017
|
Healthy review Yannik, thanks. |
yannikbehr
pushed a commit
that referenced
this pull request
Oct 18, 2021
Adds info prints, SC3 logs backups, db exports, specific SC3 install …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and specific data dir. As well as two utilities: