Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
A mistake was made, reviewer kindly suggested the proper fix.

Co-authored-by: Ju4tCode <42488585+yanyongyu@users.noreply.github.com>
  • Loading branch information
jecluis and yanyongyu committed Dec 19, 2023
1 parent 51dfe38 commit d56601a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion githubkit/webhooks/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -9862,7 +9862,7 @@ class ProjectsV2ItemEditedPropChangesPropFieldValue(GitHubWebhookModel):
"""ProjectsV2ItemEditedPropChangesPropFieldValue"""

field_type: Literal[
"single-select", "date", "number", "text", "iteration", "labels"
"single_select", "date", "number", "text", "iteration", "labels"
] = Field(default=...)
field_node_id: str = Field(default=...)

Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -264,8 +264,8 @@ types_output = "githubkit/webhooks/types.py"
# [FIXED] https://github.com/octokit/webhooks/issues/806
# "/definitions/secret_scanning_alert$resolved/properties/alert/allOf/1/properties/resolution" = { enum = ["false_positive", "wont_fix", "revoked", "used_in_tests"] }

# project v2 item edit event can contain labels
"/definitions/projects_v2_item$edited/properties/changes/properties/field_value/properties/field_type" = { enum = [ "single-select", "date", "number", "text", "iteration", "labels" ] }
# https://github.com/yanyongyu/githubkit/pull/69
"/definitions/projects_v2_item$edited/properties/changes/properties/field_value/properties/field_type" = { enum = [ "single_select", "date", "number", "text", "iteration", "labels" ] }

[tool.codegen.field_overrides]
"+1" = "plus_one"
Expand Down

0 comments on commit d56601a

Please sign in to comment.