Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add support for REST-API-VERSION based on the used schema #24

Merged

Conversation

netomi
Copy link
Contributor

@netomi netomi commented Mar 31, 2023

This PR is related to #9 and adds a REST-API-VERSION property for each Rest Client (at first I added it to the RestNamespace but that resulted in circular dependencies, maybe another place is better suited?) and adds an appropriate header when doing requests.

Tested this in my own project using githubkit as there are no tests available.

I did not regenerate the classes itself as this would clutter the PR.

@yanyongyu yanyongyu added the enhancement New feature or request label Apr 1, 2023
@yanyongyu yanyongyu merged commit b3faaad into yanyongyu:master Apr 1, 2023
@yanyongyu yanyongyu changed the title Add support for REST-API-VERSION based on the used schema Feature: Add support for REST-API-VERSION based on the used schema Apr 1, 2023
@netomi netomi deleted the add-github-rest-api-version-header branch April 1, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants