Add option to reloadOnUpdate #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 6, 2017 15:54
|
@elliotdavies Thanks for this!. LGTM, when I have a chance to test properly I'll merge. |
|
Thanks @theolampert! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've come across an issue where updating the children of the
<Flickity>component can cause it to render incorrectly. This is because React rebuilds the child DOM, which wipes out theleft: 33%(etc) styling Flickity has applied.The issue can be fixed by calling
reloadCells(). This PR adds a prop calledreloadOnUpdate, which if true will callreloadCells()whenever the component updates. It's a quick fix that's sufficient for my use case but could probably be refined further.Apologies for the formatting noise in the PR; I use Prettier and it had a field day.