Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] FIx flaky test in ConnectionLevelSparkEngineSuite #395

Closed
wants to merge 10 commits into from
Closed

[WIP] FIx flaky test in ConnectionLevelSparkEngineSuite #395

wants to merge 10 commits into from

Conversation

ulysses-you
Copy link
Contributor

@ulysses-you ulysses-you commented Mar 4, 2021

ulysses-you Closes #395 2 1 10 Target Issue Test Plan ❨?❩

Why are the changes needed?

How was this patch tested?

@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #395 (e8bdd4d) into master (2e33158) will increase coverage by 0.27%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
+ Coverage   80.49%   80.77%   +0.27%     
==========================================
  Files         101      101              
  Lines        3641     3652      +11     
  Branches      428      434       +6     
==========================================
+ Hits         2931     2950      +19     
+ Misses        492      484       -8     
  Partials      218      218              
Impacted Files Coverage Δ
...ache/kyuubi/ha/client/EngineServiceDiscovery.scala 0.00% <0.00%> (ø)
.../engine/spark/session/SparkSQLSessionManager.scala 80.43% <0.00%> (-6.67%) ⬇️
...main/scala/org/apache/kyuubi/session/package.scala 0.00% <0.00%> (ø)
...ache/kyuubi/engine/spark/SparkProcessBuilder.scala 89.33% <0.00%> (+1.99%) ⬆️
...org/apache/kyuubi/operation/ExecuteStatement.scala 74.32% <0.00%> (+6.75%) ⬆️
.../org/apache/kyuubi/session/KyuubiSessionImpl.scala 77.52% <0.00%> (+7.52%) ⬆️

@ulysses-you
Copy link
Contributor Author

seems it's a small bug, now the test is stable. cc @yaooqinn

@ulysses-you
Copy link
Contributor Author

merging to master for 1.1.0

@ulysses-you ulysses-you deleted the flaky-test branch March 5, 2021 09:14
@yaooqinn
Copy link
Member

yaooqinn commented Mar 5, 2021

I ignored the test in a previous PR

@ulysses-you ulysses-you added this to the v1.1.0 milestone Mar 8, 2021
@ulysses-you ulysses-you self-assigned this Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants