Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segfault when compiling with nginx_upstream_check_module but not using it #3

Closed
mtourne opened this issue Oct 19, 2010 · 1 comment
Closed

Segfault when compiling with nginx_upstream_check_module but not using it #3

mtourne opened this issue Oct 19, 2010 · 1 comment

Comments

@mtourne
Copy link
Collaborator

mtourne commented Oct 19, 2010

If the module is compiled in but not used, in ngx_http_upstream_check_init_shm()
(umcf->peers->peers.nelts > 0) is never true thus check_peers_ctx stays NULL.
This causes a segfault when then ngx_http_check_add_timers() is called
@yaoweibin
Copy link
Owner

Thanks for your bug report, nice catch. I have fix the problem in the new revision. This is a silly bug. I think I need a careful code review and a full test.

@anprevosto anprevosto mentioned this issue Nov 18, 2014
Open
@chauanhtuanmd chauanhtuanmd mentioned this issue Aug 1, 2016
Open
@fankeke fankeke mentioned this issue Sep 30, 2016
Open
@carlvine500 carlvine500 mentioned this issue Dec 21, 2016
Closed
@yangdailin yangdailin mentioned this issue Jan 19, 2017
Open
@mushroom11s mushroom11s mentioned this issue Oct 17, 2018
Closed
rq0net pushed a commit to rq0net/nginx_upstream_check_module that referenced this issue Dec 9, 2020
@2Fast2BCn
Merge pull request yaoweibin#3 from prune998/patch-1
34228d7 
created check_1.11.1+.patch
ngarratt pushed a commit to ngarratt/nginx_upstream_check_module that referenced this issue Jul 5, 2023
@kipras
Merge pull request yaoweibin#3 from zenedge/feature/openresty_71_ssl_…
f81a903 
…healthchecks_cleanup

OPENRESTY-71 SSL healthchecks cleanup
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yaoweibin @mtourne