Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference Ravi and Larochelle in About section #14

Open
chrisdawww opened this issue Sep 9, 2020 · 1 comment
Open

Reference Ravi and Larochelle in About section #14

chrisdawww opened this issue Sep 9, 2020 · 1 comment

Comments

@chrisdawww
Copy link

The About mini-ImageNet section cites Vinyals et al. for proposing mini-ImageNet. This is true but when they published their paper, they did not include the classes which comprise mini-ImageNet until over a year later in Appendix B of a new submission on arXiv. The Ravi and Larochelle paper you cite in your Acknowledgements section created their own split since Vinyals et al. did not provide one.

The README.md on this repo cites the Ravi and Larochelle paper, but never mentions that the train, val, and test csv files come from that paper instead of the Vinyals paper which has a very different split of classes. It would be helpful to include the information of the origin of the train, val, and test splits in the About mini-ImageNet section.

@yaoyao-liu
Copy link
Owner

Thanks a lot for reporting this valuable issue.
I've updated the README.md file and included the information you provided (I've also included your GitHub account in the acknowledgments).
You may also create a pull request to update this project so that your account name will be added to the contributors' list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants