-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase the number of characters of the Change-Id used to generate the source branch name #39
Comments
dancysoft
pushed a commit
that referenced
this issue
Oct 17, 2023
Previously gerritlab pushed commits to branches named after the local branch (or a name supplied on the command line). Now MR branches are named <final-target-branch-name>-<fullchangeid>. final-target-branch-name comes from target_branch in .gitreview, unless an override is supplied on the command line. Advantages: * The remote branch names never depend on the developer's local branch name. This means you can rename your local branch without worrying about a new set of MRs being created. * Using the full Change-Id deals with #39 Closes: #53, #39 Change-Id: I732a738272927ef5af6ff00b0b21a033b0fe41b4
dancysoft
pushed a commit
that referenced
this issue
Oct 17, 2023
Previously gerritlab pushed commits to branches named after the local branch (or a name supplied on the command line). Now MR branches are named <final-target-branch-name>-<fullchangeid>. final-target-branch-name comes from target_branch in .gitreview, unless an override is supplied on the command line. Advantages: * The remote branch names never depend on the developer's local branch name. This means you can rename your local branch without worrying about a new set of MRs being created. * Using the full Change-Id deals with #39 Closes: #53, #39 Change-Id: I732a738272927ef5af6ff00b0b21a033b0fe41b4
dancysoft
pushed a commit
that referenced
this issue
Oct 17, 2023
Previously gerritlab pushed commits to branches named after the local branch (or a name supplied on the command line). Now MR branches are named <final-target-branch-name>-<fullchangeid>. final-target-branch-name comes from target_branch in .gitreview, unless an override is supplied on the command line. Advantages: * The remote branch names never depend on the developer's local branch name. This means you can rename your local branch without worrying about a new set of MRs being created. * Using the full Change-Id deals with #39 Closes: #53, #39 Change-Id: I732a738272927ef5af6ff00b0b21a033b0fe41b4
dancysoft
pushed a commit
that referenced
this issue
Oct 17, 2023
Previously gerritlab pushed commits to branches named after the local branch (or a name supplied on the command line). Now MR branches are named <final-target-branch-name>-<fullchangeid>. final-target-branch-name comes from target_branch in .gitreview, unless an override is supplied on the command line. Advantages: * The remote branch names never depend on the developer's local branch name. This means you can rename your local branch without worrying about a new set of MRs being created. * Using the full Change-Id deals with #39 Closes: #53, #39 Change-Id: I732a738272927ef5af6ff00b0b21a033b0fe41b4
dancysoft
pushed a commit
that referenced
this issue
Oct 17, 2023
Previously gerritlab pushed commits to branches named after the local branch (or a name supplied on the command line). Now MR branches are named <final-target-branch-name>-<fullchangeid>. final-target-branch-name comes from target_branch in .gitreview, unless an override is supplied on the command line. Advantages: * The remote branch names never depend on the developer's local branch name. This means you can rename your local branch without worrying about a new set of MRs being created. * Using the full Change-Id deals with #39 Closes: #53, #39 Change-Id: I732a738272927ef5af6ff00b0b21a033b0fe41b4
dancysoft
pushed a commit
that referenced
this issue
Oct 19, 2023
Previously gerritlab pushed commits to branches named after the local branch (or a name supplied on the command line). Now MR branches are named <final-target-branch-name>-<fullchangeid>. final-target-branch-name comes from target_branch in .gitreview, unless an override is supplied on the command line. Advantages: * The remote branch names never depend on the developer's local branch name. This means you can rename your local branch without worrying about a new set of MRs being created. * Using the full Change-Id deals with #39 Other changes: * Removed unused MergeRequest._local_branch attribute. Closes: #53, #39 Change-Id: I732a738272927ef5af6ff00b0b21a033b0fe41b4
dancysoft
pushed a commit
that referenced
this issue
Oct 23, 2023
Previously gerritlab pushed commits to branches named after the local branch (or a name supplied on the command line). Now MR branches are named <final-target-branch-name>-<fullchangeid>. final-target-branch-name comes from target_branch in .gitreview, unless an override is supplied on the command line. Advantages: * The remote branch names never depend on the developer's local branch name. This means you can rename your local branch without worrying about a new set of MRs being created. * Using the full Change-Id deals with #39 Other changes: * Removed unused MergeRequest._local_branch attribute. * Added tests to exercised merge_merge_requests Closes: #53, #39 Change-Id: I732a738272927ef5af6ff00b0b21a033b0fe41b4
dancysoft
pushed a commit
that referenced
this issue
Oct 23, 2023
Previously gerritlab pushed commits to branches named after the local branch (or a name supplied on the command line). Now MR branches are named <final-target-branch-name>-<fullchangeid>. final-target-branch-name comes from target_branch in .gitreview, unless an override is supplied on the command line. Advantages: * The remote branch names never depend on the developer's local branch name. This means you can rename your local branch without worrying about a new set of MRs being created. * Using the full Change-Id deals with #39 Other changes: * Removed unused MergeRequest._local_branch attribute. * Added tests to exercised merge_merge_requests Closes: #53, #39 Change-Id: I732a738272927ef5af6ff00b0b21a033b0fe41b4
dancysoft
pushed a commit
that referenced
this issue
Oct 23, 2023
Previously gerritlab pushed commits to branches named after the local branch (or a name supplied on the command line). Now MR branches are named <final-target-branch-name>-<fullchangeid>. final-target-branch-name comes from target_branch in .gitreview, unless an override is supplied on the command line. Advantages: * The remote branch names never depend on the developer's local branch name. This means you can rename your local branch without worrying about a new set of MRs being created. * Using the full Change-Id deals with #39 Other changes: * Removed unused MergeRequest._local_branch attribute. * Added tests to exercised merge_merge_requests Closes: #53, #39 Change-Id: I732a738272927ef5af6ff00b0b21a033b0fe41b4
dancysoft
pushed a commit
that referenced
this issue
Oct 23, 2023
Previously gerritlab pushed commits to branches named after the local branch (or a name supplied on the command line). Now MR branches are named <final-target-branch-name>-<fullchangeid>. final-target-branch-name comes from target_branch in .gitreview, unless an override is supplied on the command line. Advantages: * The remote branch names never depend on the developer's local branch name. This means you can rename your local branch without worrying about a new set of MRs being created. * Using the full Change-Id deals with #39 Other changes: * Removed unused MergeRequest._local_branch attribute. * Added tests to exercise merge_merge_requests Closes: #53, #39 Change-Id: I732a738272927ef5af6ff00b0b21a033b0fe41b4
dancysoft
pushed a commit
that referenced
this issue
Oct 23, 2023
Previously gerritlab pushed commits to branches named after the local branch (or a name supplied on the command line). Now MR branches are named <final-target-branch-name>-<fullchangeid>. final-target-branch-name comes from target_branch in .gitreview, unless an override is supplied on the command line. Advantages: * The remote branch names never depend on the developer's local branch name. This means you can rename your local branch without worrying about a new set of MRs being created. * Using the full Change-Id deals with #39 Other changes: * Removed unused MergeRequest._local_branch attribute. * Added tests to exercise merge_merge_requests Closes: #53, #39 Change-Id: I732a738272927ef5af6ff00b0b21a033b0fe41b4
dancysoft
pushed a commit
that referenced
this issue
Oct 23, 2023
Previously gerritlab pushed commits to branches named after the local branch (or a name supplied on the command line). Now MR branches are named <final-target-branch-name>-<fullchangeid>. final-target-branch-name comes from target_branch in .gitreview, unless an override is supplied on the command line. Advantages: * The remote branch names never depend on the developer's local branch name. This means you can rename your local branch without worrying about a new set of MRs being created. * Using the full Change-Id deals with #39 Other changes: * Removed unused MergeRequest._local_branch attribute. * Added tests to exercise merge_merge_requests Closes: #53, #39 Change-Id: I732a738272927ef5af6ff00b0b21a033b0fe41b4
dancysoft
pushed a commit
that referenced
this issue
Oct 24, 2023
Previously gerritlab pushed commits to branches named after the local branch (or a name supplied on the command line). Now MR branches are named <final-target-branch-name>-<fullchangeid>. final-target-branch-name comes from target_branch in .gitreview, unless an override is supplied on the command line. Advantages: * The remote branch names never depend on the developer's local branch name. This means you can rename your local branch without worrying about a new set of MRs being created. * Using the full Change-Id deals with #39 Other changes: * Removed unused MergeRequest._local_branch attribute. * Added tests to exercise merge_merge_requests Closes: #53, #39 Change-Id: I732a738272927ef5af6ff00b0b21a033b0fe41b4
thcipriani
pushed a commit
that referenced
this issue
Oct 25, 2023
Previously gerritlab pushed commits to branches named after the local branch (or a name supplied on the command line). Now MR branches are named <final-target-branch-name>-<fullchangeid>. final-target-branch-name comes from target_branch in .gitreview, unless an override is supplied on the command line. Advantages: * The remote branch names never depend on the developer's local branch name. This means you can rename your local branch without worrying about a new set of MRs being created. * Using the full Change-Id deals with #39 Other changes: * Removed unused MergeRequest._local_branch attribute. * Added tests to exercise merge_merge_requests Closes: #53, #39 Change-Id: I732a738272927ef5af6ff00b0b21a033b0fe41b4
Done in #54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now 4 characters of the Change-Id are used, leaving the very real possibility of a collision in the source branch names of two different commits. I propose increasing to at least 8 characters, maybe even more. Using the whole Change-Id would provide collision resistance on par with Gerrit.
The text was updated successfully, but these errors were encountered: