Fix how vendored assets are imported to work when addon is a dependency of another addon #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this.app is only available for addons who are a direct dependency of the consuming app. In the case where the addon is a dependency of another addon, this.app is not defined. However, the included function is passed a "parent" which is either the consuming app or the parent addon. Seeing as we use ember-colpick as a dependency of an addon which is itself a dependency of the app, we need this.app fails and we need to use app instead.
lukemelia
approved these changes
Oct 10, 2023
lukemelia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this.appis only available for addons who are a direct dependency of the consuming app. (docs)In the case where the addon is a dependency of another addon, this.app is not defined.
However, the
includedfunction is passed aparentwhich is either the consuming app or the parent addon. (docs)Seeing as we use ember-colpick as a dependency of an addon which is itself a dependency of the app,
this.appfails and we need to useappinstead. We made this patch to get around this.Would you consider merging this in to the mainline branch so we can remove our fork?