Fix containerClassNames for rendered in place modals

yapplabs · Feb 21, 2023 · 6ba1e9f · 6ba1e9f
1 parent d16dded
commit 6ba1e9f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 15 deletions.
diff --git a/addon/components/in-place-dialog.js b/addon/components/in-place-dialog.js
@@ -5,23 +5,18 @@ import layout from '../templates/components/in-place-dialog';
 @tagName('')
 @templateLayout(layout)
 export default class InPlaceDialog extends Component {
-  containerClass = null; // passed in
-
-  init() {
-    super.init(...arguments);
-
-    this.containerClassNames = [
+  get containerClassNamesString() {
+    const addonClassNamesString = [
       'ember-modal-dialog',
       'ember-modal-dialog-in-place',
       'emd-in-place',
-    ]; // set this in a subclass definition
-  }
+    ].join(' ');
 
-  get containerClassNamesString() {
-    return (
+    const containerClassNamesString =
       (this.containerClassNames?.join && this.containerClassNames?.join(' ')) ||
       this.containerClassNames ||
-      ''
-    );
+      '';
+
+    return `${addonClassNamesString} ${containerClassNamesString}`;
   }
 }
diff --git a/addon/templates/components/in-place-dialog.hbs b/addon/templates/components/in-place-dialog.hbs
@@ -1,5 +1,3 @@
-<div
-  class={{concat this.containerClassNamesString " " this.attachmentClass " " this.containerClass}}
->
+<div class={{concat this.containerClassNamesString " " this.attachmentClass " " this.containerClass}}>
   {{yield}}
 </div>