Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why click instead of "change" event? #6

Closed
toranb opened this issue Jan 19, 2015 · 3 comments
Closed

Why click instead of "change" event? #6

toranb opened this issue Jan 19, 2015 · 3 comments

Comments

@toranb
Copy link

toranb commented Jan 19, 2015

I noticed in the component you handle a "click" event but hacking around with my own component for this revealed that you could also listen to the change event.

I'm just curious why the team at yapp went with click (ie- is a cross browser thing / mobile browser thing / or just the right thing for the radio button input) ?

Thanks for an awesome OSS project team!

@raycohen
Copy link
Contributor

Hey @toranb. I took a shot at restructuring this to use the change event.

If you have a chance, I'd like your feedback on #7?

Thanks!

@toranb
Copy link
Author

toranb commented Jan 23, 2015

Awesome! I was still curious about the question I asked above (ie- why click over change / what should people be doing with the radio button if they are forced to implement it outside of this project for whatever reason) ?

Thanks for the great OSS contributions ! Can't wait to see these merged in!

@raycohen
Copy link
Contributor

1.0.0 now responds to the change event

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants