Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use change event #7

Merged
merged 19 commits into from
Mar 31, 2015
Merged

Use change event #7

merged 19 commits into from
Mar 31, 2015

Conversation

raycohen
Copy link
Contributor

This PR is an attempt to simplify the implementation and more completely cover the ways that a radio button can become checked, and emit less additional DOM elements when not used as a block.

There are significant changes:

  • Non-block form of component now emits only an input[type=radio] element
  • Block form emits a label element wrapping the input and content. No more span.
  • checked and disabled are not bound as classNames (they were on the span previously, perhaps they should be on the label element)
  • Added meaningful tests.

@toranb
Copy link

toranb commented Jan 23, 2015

Wow this looks great! I really like the changes (greatly simplified this component for those reading the code).

…rsion of the `radio-button` component. bump version to 1.0.0
…abel element wrapping input and content) and non-block form (solo input element)
@lukemelia
Copy link
Contributor

Changes looks good to me. 👍 We may want to branch current master as pre-htmlbars or something.

@raycohen raycohen mentioned this pull request Jan 25, 2015
@raycohen raycohen merged commit ed133c8 into master Mar 31, 2015
@raycohen raycohen changed the title [Ready For Testing] Use change event Use change event Mar 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants