Fix getDOM for Ember 2.6/2.7 in integration tests #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemelia
approved these changes
Jun 11, 2017
|
OK, @simonihmig #94 is merged. This is ready for a rebase. Thanks! |
simonihmig
force-pushed
the
fix-dom-service
branch
3 times, most recently
from
c392490
to
1651fda
Compare
simonihmig
force-pushed
the
fix-dom-service
branch
from
1651fda
to
e7271bc
Compare
|
Ok, finally got the rebase right! 😬 |
|
Thanks for your work @simonihmig. Published as 0.5.2 |
|
@lukemelia great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #77. The exception mentioned there came up in integration tests. As there were no integration tests here, this was not catched. Added a simple one, and indeed that was failing for Ember 2.6/2.7 with the mentioned exception!
The change here reverts the
getDOMfunction to use the same code that was used in 0.4.1 (the last working version that was not affected by #77) for pre Glimmer2 versions of Ember, while using the newer code path introduced in 0.5.x for Glimmer2 apps (using the-documentservice).This PR includes #94, so merge that first!