Added RS232 vs RS485 support #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added pre-pend of /Z for all nondefault interfaces of RS485 in config file
for more information, see https://pre-commit.ci
Committed an earlier version, this one contains more updates
for more information, see https://pre-commit.ci
|
I'm editing the top comment with a checklist of small administrative things that we need to do before merge. Important question: does this work correctly for RS485 valves that DO have an address? Does the Z still get prepended in that case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added pre-pend of /Z for all nondefault interfaces of RS485 in config file
TODO:
hardwarefield of toml to indicate increased hardware support, rerender avpr