Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set env variable FORCE_COLOR. #56

Merged
merged 1 commit into from
Dec 18, 2017
Merged

Set env variable FORCE_COLOR. #56

merged 1 commit into from
Dec 18, 2017

Conversation

coreyfarrell
Copy link
Contributor

This ensures that chalk uses always color instead of detecting from the
environment. I believe when travis-ci runs the test it chalk detects
that color is not support.

The failure can be reproduced locally (without this patch) by running:

# Fails
env -i npm test --scripts-prepend-node-path

# Passes due to TERM environment
env -i TERM=xterm npm test --scripts-prepend-node-path

I set FORCE_COLOR as it's documented by chalk as how to disable detection.

This ensures that chalk uses always color instead of detecting from the
environment.  I believe when travis-ci runs the test it chalk detects
that color is not support.
@bcoe
Copy link
Member

bcoe commented Dec 18, 2017

@coreyfarrell great find 👍

@bcoe bcoe merged commit 7350e36 into yargs:master Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants