Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: downgrades strip-ansi to version 3.0.1 (#54)" #55

Merged
merged 1 commit into from
Dec 14, 2017
Merged

Revert "fix: downgrades strip-ansi to version 3.0.1 (#54)" #55

merged 1 commit into from
Dec 14, 2017

Conversation

coreyfarrell
Copy link
Contributor

This reverts commit 5764c46.

I enabled travis-ci for my github fork of cliui and was unable to reproduce the build failure. Posting this pull request to see if the issue has resolved itself, or if somehow my travis-ci account tests this commit differently.

@coreyfarrell
Copy link
Contributor Author

Just in case it makes any difference, these are the version changes found from npm ls results between failure and success:

acorn@5.1.2 -> 5.2.1
commander@2.11.0 -> 2.12.2
conventional-changelog@1.1.6 -> 1.1.7
conventional-changelog-angular@1.5.1 -> 1.5.2
conventional-changelog-atom@0.1.1 -> 0.1.2
conventional-changelog-codemirror@0.2.0 -> 0.2.1
conventional-changelog-core@1.9.2 -> 1.9.3
conventional-changelog-ember@0.2.8 -> 0.2.9
conventional-changelog-eslint@0.2.0 -> 0.2.1
conventional-changelog-express@0.2.0 -> 0.2.1
conventional-changelog-jshint@0.2.0 -> 0.2.1
conventional-changelog-writer@2.0.1 -> 2.0.2
conventional-commits-filter@1.0.0 -> 1.1.0
conventional-commits-parser@2.0.0 -> 2.0.1
es5-ext@0.10.35 -> 0.10.37
es6-iterator@2.0.1 -> 2.0.3
espree@3.5.1 -> 3.5.2
git-raw-commits@1.2.0 -> 1.3.0
git-semver-tags@1.2.2 -> 1.2.3
handlebars@4.0.10 -> 4.0.11
ignore@3.3.5 -> 3.3.7
ini@1.3.4 -> 1.3.5
interpret@1.0.4 -> 1.1.0
is-buffer@1.1.5 -> 1.1.6
is-path-inside@1.0.0 -> 1.0.1
q@1.5.0 -> 1.5.1
resolve@1.4.0 -> 1.5.0

@bcoe
Copy link
Member

bcoe commented Dec 14, 2017

@coreyfarrell thank you 👍

@bcoe bcoe merged commit a710255 into yargs:master Dec 14, 2017
@bcoe
Copy link
Member

bcoe commented Dec 18, 2017

@coreyfarrell your changes should be available in cliui@4.0.0, would love your feedback if you don't mind taking it for a spin.

@coreyfarrell
Copy link
Contributor Author

To be honest I'm not a direct user, I was looking to reduce the size of npm i nyc and cliui caught my attention because it pulled old versions of modules while nyc or it's other deps pulled newer versions. Unfortunately without updating wrap-ansi the goal is not accomplished.

I tried updating wrap-ansi but the way it works has changed (and trim: false doesn't restore previous behavior). I'm planning to post a bug against that module but I'm not sure I actually understand what wrap-ansi should do. I'm not sure if the 2.x or 3.x behavior is correct, or if both are wrong. Whitespace trimming is changed by the presence or lack of ANSI escape codes, I'm not sure that is the correct behavior. In fact this is why cliui test requires FORCE_COLOR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants