feat: add an isTTY check (#3)

BREAKING CHANGE: stdio/stderr will not be set to blocking if isTTY === false
yargs · May 17, 2016 · 66ce277 · 66ce277
1 parent 7d0c45e
commit 66ce277
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -1,6 +1,6 @@
 module.exports = function (blocking) {
   [process.stdout, process.stderr].forEach(function (stream) {
-    if (stream._handle && typeof stream._handle.setBlocking === 'function') {
+    if (stream._handle && stream.isTTY && typeof stream._handle.setBlocking === 'function') {
       stream._handle.setBlocking(blocking)
     }
   })

diff --git a/test/fixtures/yargs-497-stderr.js b/test/fixtures/yargs-497-stderr.js
@@ -1,5 +1,9 @@
 #!/usr/bin/env node
 
+// pretend we are a TTY
+process.stdout.isTTY = true
+process.stderr.isTTY = true
+
 // see: https://github.com/yargs/yargs/issues/497
 var buffer = ''
 for (var i = 0; i < 3000; i++) {

diff --git a/test/fixtures/yargs-497-stdout.js b/test/fixtures/yargs-497-stdout.js
@@ -1,5 +1,9 @@
 #!/usr/bin/env node
 
+// pretend we are a TTY
+process.stdout.isTTY = true
+process.stderr.isTTY = true
+
 // see: https://github.com/yargs/yargs/issues/497
 var buffer = ''
 for (var i = 0; i < 3000; i++) {