feat: no longer coerce numbers by default #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature feels too magical, and is leads to a variety of bug reports on yargs BREAKING CHANGE: folks must now opt in to parse-numbers, using configuration.
|
open question to me, is it worth forcing a large number of folks in the community to update their usage of the yargs/yargs-parser API, to remove this feature that I think is too magical and causes a variety of bugs: yargs/yargs#1099 alternatively, perhaps we look for leading |
|
after seeing the number of test failures in yargs from this change (not to mention the number of tests that needed to be updated in yargs-parser) opted for this less drastic change: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly big breaking change, but I think worthwhile. yargs and yargs-parser allow a user to opt in to numeric parsing on an option by option basis. Let's not magically convert strings to numbers by default, as this causes problems for phone #s, UUIDs, etc.
BREAKING CHANGE: folks must now opt in to parse-numbers, using configuration.