fix: dot-notation now respects strip-dashed #288
Conversation
|
Actually, just realized, this may infinitely a circular reference into a coerced arg.... fix pending.... |
Mike111177
force-pushed
the
fix_dot-notation_doesn't_respect_strip-dashed
branch
from
6982e63
to
759aba7
Compare
|
Fixed, ready |
Mike111177
force-pushed
the
fix_dot-notation_doesn't_respect_strip-dashed
branch
from
759aba7
to
5a2f77e
Compare
|
Hey @Mike111177 sorry for the slow reply. Bother you to rebase against the main branch, I've been working on landing some of our TypeScript work. |
|
@Mike111177 just a friendly note, to ask whether this is still something you'd like to see landed. |
Mike111177
force-pushed
the
fix_dot-notation_doesn't_respect_strip-dashed
branch
from
5a2f77e
to
8f40f1f
Compare
|
Completely forgot about it lol, here you go. |
Mike111177
force-pushed
the
fix_dot-notation_doesn't_respect_strip-dashed
branch
from
8f40f1f
to
e9dd129
Compare
|
@Mike111177 I owe you review, haven't forgotten about this myself. |
|
@@Mike111177 shoot, with my rebase I seem to now be in a position where tests aren't passing. |
There was a problem hiding this comment.
Sorry for being so slow with review on this issue, I've been a little bit swamped.
The reason I didn't land immediately, is that I'm a little concerned about adding so much logic related to handling a single config variation for dot-notation.
Could we figure out a way to pull the dot-notation check into a helper function perhaps that we could reuse to make dot notation respect configuration in a more general sense? I feel like there are many config settings that dot notation doesn't respect.
|
@Mike111177 just checking if you still want to land this. |
|
@Mike111177 let me know when/if you would like to dust this off 👍 |
Fixes #223