Global middleware don't work in 12.0.1

[jaguilar87]

I've tried this code:

const yargs = require('yargs');

const mwFunc1 = argv => console.log('I\'m a middleware function');
const mwFunc2 = argv => console.log('I\'m another middleware function');

yargs
  .command('myCommand', 'some command', {}, function(argv){
    console.log('Running myCommand!');
  })
  .middleware([mwFunc1, mwFunc2]).argv;

OUTPUT:

Running myCommand!

No trace of the middlewares :(

[aorinevo]

Hi @jaguilar87, I was able to reproduce the issue. I resolved it by calling middleware first before the command method.

#!/usr/bin/env node
const yargs = require('yargs');

const mwFunc1 = argv => console.log('I\'m a middleware function');
const mwFunc2 = argv => console.log('I\'m another middleware function');

console.log('test');
yargs
  .middleware([mwFunc1, mwFunc2])
  .command('myCommand', 'some command', {}, function(argv){
    console.log(argv);
    console.log('Running myCommand!');
  })
  .argv;

[bcoe]

the order of the middleware definition, vs., the order of the command definition shouldn't matter. Definitely a bug we'll dig into.

[aorinevo]

PR #1180 fixes this issue.

[bcoe]

@jaguilar87 @aorinevo please try npm i yargs@next which should correct this issue; if it's looking good, I can promote a new release early next week.