support for colored commands in help output

[NewFuture]

const colors = require("ansi-colors");
require("yargs")
  .command(colors.red('test'),"just test")
  .strict()

when run my-cmd test, it works with v15.3.1;

but it breaks in v15.4.1, because test is not matched with colors.red('test')

[bcoe]

@NewFuture It was unintended behavior that colors.red('test') ever matched the string "test"... as colors.red() adds ansi escape codes, meaning the string is actually something like \u001b[31mtest.

I'm honestly not sure that this feature is something we're interested in making an effort to support, it would complicate the internal representation of the command, and we'd need to make an active effort to strip color codes wherever we perform a comparison.

[NewFuture]

Thanks, @bcoe.
I mostly agree with you. but it worked in the early versions (a hidden breaking change?)

In addition, this behavior is a greate feature to create colorful commands.

[bcoe]

@NewFuture happy to keep this open as a feature request. But, I think support would have always been somewhat broken, since there are a variety of places in the codebase where we perform a string comparison to check for command name.

tldr; even though this behavior might have changed at some point, I don't think it's worthwhile taking a new major version for yargs, or to make an effort to revert the change that was the culprit.