New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More yargs translations needed #649

Closed
nexdrew opened this Issue Oct 10, 2016 · 25 comments

Comments

Projects
None yet
@nexdrew
Member

nexdrew commented Oct 10, 2016

Hello gracious OSS authors! The yargs team needs your help once again to translate the following into various languages:

  1. "aliases:" for command aliases (added in PR #647), should be line 13 of each locale file
  2. "Did you mean %s?" for recommending commands (added in PRs #562, #580), should be line 38 of each locale file

I apologize for directly pinging you, but I only do so because you have been a valued contributor in the past. If you get a chance, please either leave a comment on this issue with the requested translations or (better yet) submit a PR! 😺

As always, please feel free to ask questions , say "hi" 👋, or tell us to buzz off 🐝. Regardless, we thank you for your contributions!

Update: Thanks to all who have contributed new languages as well, you are awesome!

  • hi.json
  • hu.json
  • ru.json
  • th.json
@kamilogorek

This comment has been minimized.

Show comment
Hide comment
@kamilogorek

kamilogorek Oct 10, 2016

Contributor

There you go! :) alias is commonly used word in polish (mostly in IT), so I just pluralized it, as it should be easily understandable to everyone.

Contributor

kamilogorek commented Oct 10, 2016

There you go! :) alias is commonly used word in polish (mostly in IT), so I just pluralized it, as it should be easily understandable to everyone.

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Oct 10, 2016

Collaborator

I think @michaalbert would like to give adding a Russian translation a try later today! =)

Collaborator

addaleax commented Oct 10, 2016

I think @michaalbert would like to give adding a Russian translation a try later today! =)

@dgrcode

This comment has been minimized.

Show comment
Hide comment
@dgrcode

dgrcode Oct 10, 2016

Contributor

I'll send the Spanish translation! But I have a question first. The translation for aliases depends on the context. Could you give me a couple of examples where "aliases" is going to be written?
Thanks!

Contributor

dgrcode commented Oct 10, 2016

I'll send the Spanish translation! But I have a question first. The translation for aliases depends on the context. Could you give me a couple of examples where "aliases" is going to be written?
Thanks!

@maxrimue

This comment has been minimized.

Show comment
Hide comment
@maxrimue

maxrimue Oct 10, 2016

Member

@dgrcode "Aliases" is used to reference something like different names for the same command or option. Say if we have the command add and want users to be able to call it also using a different name for the same command, say addFiles, we do so by creating the alias addFiles of add. The translation will appear in a box after a command, like this:

add [alias: addFiles]

Does that answer your question?

Member

maxrimue commented Oct 10, 2016

@dgrcode "Aliases" is used to reference something like different names for the same command or option. Say if we have the command add and want users to be able to call it also using a different name for the same command, say addFiles, we do so by creating the alias addFiles of add. The translation will appear in a box after a command, like this:

add [alias: addFiles]

Does that answer your question?

disjukr added a commit that referenced this issue Oct 11, 2016

@babhishek21

This comment has been minimized.

Show comment
Hide comment
@babhishek21

babhishek21 Oct 11, 2016

Contributor

If anyone needs Hindi or Bengali translations, let me know! 😄

Contributor

babhishek21 commented Oct 11, 2016

If anyone needs Hindi or Bengali translations, let me know! 😄

@maxrimue

This comment has been minimized.

Show comment
Hide comment
@maxrimue

maxrimue Oct 11, 2016

Member

@babhishek21 Ohh that would be so awesome! If you would like to do it, simply create the new translation files using the existing ones in the locale/ folder as a template. If you have just any questions, go ahead 😄

Member

maxrimue commented Oct 11, 2016

@babhishek21 Ohh that would be so awesome! If you would like to do it, simply create the new translation files using the existing ones in the locale/ folder as a template. If you have just any questions, go ahead 😄

@babhishek21

This comment has been minimized.

Show comment
Hide comment
@babhishek21

babhishek21 Oct 11, 2016

Contributor

Just one quick question! Are you looking only for native script translations (Hindi uses the Devnagari script and looks like हिन्दी ; Bangla (Bengali) looks like বাংলা )? Transliterated versions are also available.

Contributor

babhishek21 commented Oct 11, 2016

Just one quick question! Are you looking only for native script translations (Hindi uses the Devnagari script and looks like हिन्दी ; Bangla (Bengali) looks like বাংলা )? Transliterated versions are also available.

@maxrimue

This comment has been minimized.

Show comment
Hide comment
@maxrimue

maxrimue Oct 11, 2016

Member

@babhishek21 Hmm I'm not sure if that'll work, I don't know to be honest 😄 Perhaps for compatibility reasons, we should go with the transliterated versions, what do you think?
Edit: Oh btw it's really important the file names use the official locale codes to be recognised by y18n

Member

maxrimue commented Oct 11, 2016

@babhishek21 Hmm I'm not sure if that'll work, I don't know to be honest 😄 Perhaps for compatibility reasons, we should go with the transliterated versions, what do you think?
Edit: Oh btw it's really important the file names use the official locale codes to be recognised by y18n

@babhishek21

This comment has been minimized.

Show comment
Hide comment
@babhishek21

babhishek21 Oct 11, 2016

Contributor

Hindi (Devnagari) works with UTF-8. Bangla also works with Unicode. I'll take a look at the other translations to see the range of type support. Should I perhaps make separate issues for these?

Contributor

babhishek21 commented Oct 11, 2016

Hindi (Devnagari) works with UTF-8. Bangla also works with Unicode. I'll take a look at the other translations to see the range of type support. Should I perhaps make separate issues for these?

@dgrcode

This comment has been minimized.

Show comment
Hide comment
@dgrcode

dgrcode Oct 11, 2016

Contributor

@maxrimue This answers my question! I'll send a pull request with the translations in a few minutes

Contributor

dgrcode commented Oct 11, 2016

@maxrimue This answers my question! I'll send a pull request with the translations in a few minutes

@maxrimue

This comment has been minimized.

Show comment
Hide comment
@maxrimue

maxrimue Oct 11, 2016

Member

@babhishek21 Yeah, separate pull requests would be appreciated. Thanks for dealing with this 😄

Member

maxrimue commented Oct 11, 2016

@babhishek21 Yeah, separate pull requests would be appreciated. Thanks for dealing with this 😄

@michaalbert

This comment has been minimized.

Show comment
Hide comment
@michaalbert

michaalbert Oct 11, 2016

Contributor

Hi, I have a question about translating "Implications failed". Could someone give a general description of situations when this is used? It can't be transalted literally so I have to somehow describe it.

Contributor

michaalbert commented Oct 11, 2016

Hi, I have a question about translating "Implications failed". Could someone give a general description of situations when this is used? It can't be transalted literally so I have to somehow describe it.

@nexdrew

This comment has been minimized.

Show comment
Hide comment
@nexdrew

nexdrew Oct 11, 2016

Member

@michaalbert This is a validation error where the use of one argument implies (requires) the use of another argument. So "Implications failed" basically means "You provided the first argument mentioned but didn't provide the second argument mentioned, which is required when providing the first argument."

That's obviously verbose, so if you can figure out the most concise way of saying the same thing, that would be great. Thanks! And please let us know if you have any additional questions.

Member

nexdrew commented Oct 11, 2016

@michaalbert This is a validation error where the use of one argument implies (requires) the use of another argument. So "Implications failed" basically means "You provided the first argument mentioned but didn't provide the second argument mentioned, which is required when providing the first argument."

That's obviously verbose, so if you can figure out the most concise way of saying the same thing, that would be great. Thanks! And please let us know if you have any additional questions.

@michaalbert

This comment has been minimized.

Show comment
Hide comment
@michaalbert

michaalbert Oct 11, 2016

Contributor

@nexdrew thanks! So would something like "The given command requires additional arguments" be okay or is that too unspecific?

Contributor

michaalbert commented Oct 11, 2016

@nexdrew thanks! So would something like "The given command requires additional arguments" be okay or is that too unspecific?

@nexdrew

This comment has been minimized.

Show comment
Hide comment
@nexdrew

nexdrew Oct 11, 2016

Member

@michaalbert That would probably be ok, but the message will be followed by text like x -> y, where x is the argument you gave and y is the argument you didn't give, so it might need to be a bit more specific to avoid confusion over x pointing to y. Not sure, what do you think?

Member

nexdrew commented Oct 11, 2016

@michaalbert That would probably be ok, but the message will be followed by text like x -> y, where x is the argument you gave and y is the argument you didn't give, so it might need to be a bit more specific to avoid confusion over x pointing to y. Not sure, what do you think?

@michaalbert

This comment has been minimized.

Show comment
Hide comment
@michaalbert

michaalbert Oct 11, 2016

Contributor

@nexdrew Okay, then "The given argument requires the following additional argument:" makes more sense.

Contributor

michaalbert commented Oct 11, 2016

@nexdrew Okay, then "The given argument requires the following additional argument:" makes more sense.

@nexdrew

This comment has been minimized.

Show comment
Hide comment
@nexdrew

nexdrew Oct 11, 2016

Member

@michaalbert That sounds perfect, thanks!

Member

nexdrew commented Oct 11, 2016

@michaalbert That sounds perfect, thanks!

@wolframtheta

This comment has been minimized.

Show comment
Hide comment
@wolframtheta

wolframtheta Oct 13, 2016

Hi @nexdrew do you want a Catalan translation?

wolframtheta commented Oct 13, 2016

Hi @nexdrew do you want a Catalan translation?

@nexdrew

This comment has been minimized.

Show comment
Hide comment
@nexdrew

nexdrew Oct 13, 2016

Member

Hi @wolframtheta, that would be great! Just add a new ca.json file to the locales directory. Thanks!

Member

nexdrew commented Oct 13, 2016

Hi @wolframtheta, that would be great! Just add a new ca.json file to the locales directory. Thanks!

@madcampos

This comment has been minimized.

Show comment
Hide comment
@madcampos

madcampos Oct 16, 2016

Contributor

Hello, I have a question, is the pt_BR translation open? If so, I wish to work on it if I may.

Contributor

madcampos commented Oct 16, 2016

Hello, I have a question, is the pt_BR translation open? If so, I wish to work on it if I may.

@babhishek21

This comment has been minimized.

Show comment
Hide comment
@babhishek21

babhishek21 Oct 16, 2016

Contributor

@madcampos Check among the current PRs if any pending changes exist for locales/pt_BR.json. Other than that, as you can see from the checklist in the Issue Description, there is work to be done there.

Contributor

babhishek21 commented Oct 16, 2016

@madcampos Check among the current PRs if any pending changes exist for locales/pt_BR.json. Other than that, as you can see from the checklist in the Issue Description, there is work to be done there.

madcampos added a commit to madcampos/yargs that referenced this issue Oct 16, 2016

Add pt_BR translations to #649
Address brazilian portuguese translations for `aliases:` and `Did you mean %s?`
@zkat

This comment has been minimized.

Show comment
Hide comment
@zkat

zkat Oct 16, 2016

Contributor

@madcampos: for the record, pt_BR isn't one of my main langs so pleeease feel free to take over it and correct any awkwardness I put in there!

Contributor

zkat commented Oct 16, 2016

@madcampos: for the record, pt_BR isn't one of my main langs so pleeease feel free to take over it and correct any awkwardness I put in there!

@madcampos

This comment has been minimized.

Show comment
Hide comment
@madcampos

madcampos Oct 17, 2016

Contributor

@zkat I'm brazilian so I can help with that, no problem. 😉

Contributor

madcampos commented Oct 17, 2016

@zkat I'm brazilian so I can help with that, no problem. 😉

@ghost ghost referenced this issue Oct 22, 2016

Merged

Created nl.json #687

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Oct 22, 2016

Hiya
Although it wasn't on the list, I did create a Dutch translation (PR #687 )
Happy Hacktoberfest!

ghost commented Oct 22, 2016

Hiya
Although it wasn't on the list, I did create a Dutch translation (PR #687 )
Happy Hacktoberfest!

@lrlna lrlna removed the hacktoberfest label Nov 10, 2016

@bcoe

This comment has been minimized.

Show comment
Hide comment
@bcoe

bcoe Dec 29, 2016

Member

I declare this a successful hacktoberfest (two months later :p), thanks everyone who contributed.

Member

bcoe commented Dec 29, 2016

I declare this a successful hacktoberfest (two months later :p), thanks everyone who contributed.

@bcoe bcoe closed this Dec 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment