Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ts): init typescript conf + tsify is-promise #1587

Merged
merged 7 commits into from Mar 20, 2020

Conversation

mleguen
Copy link
Member

@mleguen mleguen commented Mar 11, 2020

First step of #1586.

It should not have any impact on user projects (neither js nor ts).

Includes linting of ts code.

Tested with npm pack too: the only change in the package file list is the replacement of lib/is-promise.js by the compiled build/lib/is-promise.js.

EDIT: updated path now that ts files are also in the lib dir

@mleguen mleguen requested a review from bcoe March 11, 2020 11:52
@bcoe
Copy link
Member

bcoe commented Mar 11, 2020

@mleguen convince you to try out https://www.npmjs.com/package/gts for linting? this would help keep yargs consistent with the TypeScript configuration I use at work, which would be awesome.

@mleguen
Copy link
Member Author

mleguen commented Mar 12, 2020

@bcoe In fact, I used standard to keep yargs consistent between js and ts linting, but no problem for me: always ready to try some new tool :-)

@bcoe
Copy link
Member

bcoe commented Mar 12, 2020

@mleguen depending on our timeline, I'd love for us to test 2.x.x, which requires Node 8, but has a variety of improvements -- it could be used for both our JS and TypeScript linting.

@mleguen
Copy link
Member Author

mleguen commented Mar 13, 2020

@bcoe What I finally did not to block this PR is to use gts 2.x only for the ts configuration (and script names).

We could later use it for linting too as soon as we drop support for node 8 (but let's not fight 2 battles at the same time).

@mleguen
Copy link
Member Author

mleguen commented Mar 13, 2020

@bcoe ready for review

@mleguen
Copy link
Member Author

mleguen commented Mar 19, 2020

@bcoe I tsified test/is-promise too in this PR to stay coherent

Copy link
Member

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mleguen great work, I'm really happy with this start.

@mleguen mleguen merged commit cd6e048 into master Mar 20, 2020
@mleguen mleguen deleted the 1586-tsify-is-promise branch March 20, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants