New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ts): init typescript conf + tsify is-promise #1587
Conversation
@mleguen convince you to try out https://www.npmjs.com/package/gts for linting? this would help keep yargs consistent with the TypeScript configuration I use at work, which would be awesome. |
@bcoe In fact, I used standard to keep yargs consistent between js and ts linting, but no problem for me: always ready to try some new tool :-) |
@mleguen depending on our timeline, I'd love for us to test |
@bcoe What I finally did not to block this PR is to use gts 2.x only for the ts configuration (and script names). We could later use it for linting too as soon as we drop support for node 8 (but let's not fight 2 battles at the same time). |
fba226c
to
c0d3d0f
Compare
@bcoe ready for review |
75e1431
to
5bb5f1f
Compare
@bcoe I tsified test/is-promise too in this PR to stay coherent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mleguen great work, I'm really happy with this start.
First step of #1586.
It should not have any impact on user projects (neither js nor ts).
Includes linting of ts code.
Tested with
npm pack
too: the only change in the package file list is the replacement oflib/is-promise.js
by the compiledbuild/lib/is-promise.js
.EDIT: updated path now that ts files are also in the lib dir