Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ts): tsify lib/completion #1601

Merged
merged 3 commits into from
Mar 26, 2020
Merged

chore(ts): tsify lib/completion #1601

merged 3 commits into from
Mar 26, 2020

Conversation

mleguen
Copy link
Member

@mleguen mleguen commented Mar 25, 2020

Follow up of the 2nd step of #1586: this PR tsifies the completion module.

@mleguen mleguen mentioned this pull request Mar 25, 2020
Closed
bcoe
bcoe approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, I'm really appreciating the incremental approach you're taking.

@mleguen mleguen merged commit fc18a33 into master Mar 26, 2020
@mleguen mleguen deleted the 1586-ts-completion branch March 26, 2020 18:07
@mleguen
Copy link
Member Author

mleguen commented Mar 26, 2020

@bcoe let's take the same method for async handling once we are done with tyepscript :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mleguen @bcoe