Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ts): tsify usage #1606

Merged
merged 5 commits into from
Apr 3, 2020
Merged

chore(ts): tsify usage #1606

merged 5 commits into from
Apr 3, 2020

Conversation

mleguen
Copy link
Member

@mleguen mleguen commented Apr 1, 2020

Follow up of the 2nd step of #1586: this PR tsifies the usage module.

A check was added too to ensure we never unfreeze usage more than we freezed it (thanks typescript for pointing out that freezes.pop() could return undefined!)

Copy link
Member

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This work continues to be phenomenal @mleguen:

  1. I appreciate that you're updating all the code first, and not the tests; so that we have a good safety harness as the conversion happens.
  2. it's exciting to see that TypeScript is helping catch things already.
  3. It's pretty amazing to see this codebase gradually evolve into the future 😄

gts 2.x is pretty much ready to go FYI, we just updated all our libraries to it.

@bcoe
Copy link
Member

bcoe commented Apr 3, 2020

@mleguen
Copy link
Member Author

mleguen commented Apr 3, 2020

Thanks @bcoe

I appreciate that you're updating all the code first, and not the tests; so that we have a good safety harness as the conversion happens.

Well... It is not exactly what I intended to do at first :-) But as most tests are not depending on the module they test, but directly on yargs, there is no easy way for me to update the tests until yargs is tsified.

This is something I already noticed before, and something I think we should tackle in a near future as we do not really have unit tests, only integration ones. This will be a real problem for async developments, for example.

@mleguen mleguen merged commit c5311a3 into master Apr 3, 2020
@mleguen mleguen deleted the 1586-ts-usage branch April 3, 2020 07:15
@mleguen
Copy link
Member Author

mleguen commented Apr 3, 2020

@bcoe

couldn't find your twitter

You won't find it as I never felt the need for a twitter account :-)

Thanks anyway for your kind word there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants