fix: do not crash completion when having negable options #2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
force-pushed
the
completion-fixes
branch
from
74e8eb2
to
0838d77
Compare
bcoe
reviewed
Apr 27, 2023
Current completion crashes when using ZSH and having negable options.
```
[error] TypeError: Cannot read properties of undefined (reading 'find')
at D.completeOptionKey (//node_modules/yargs/build/index.cjs:1255:20)
at //node_modules/yargs/build/index.cjs:1191:37
at Array.forEach (<anonymous>)
at D.optionCompletions (//node_modules/yargs/build/index.cjs:1184:26)
at D.defaultCompletion (//node_modules/yargs/build/index.cjs:1158:12)
at n (//node_modules/yargs/build/index.cjs:1313:23)
at D.getCompletion (//node_modules/yargs/build/index.cjs:1314:31)
at te.[runYargsParserAndExecuteCommands] (//node_modules/yargs/build/index.cjs:3161:27)
at _.parseAndUpdateUsage (//node_modules/yargs/build/index.cjs:426:8)
at _.applyBuilderUpdateUsageAndParse (//node_modules/yargs/build/index.cjs:412:17)
```
alan-agius4
force-pushed
the
completion-fixes
branch
from
0838d77
to
28d55e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current completion crashes when using ZSH and having negable options.