Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add greenkeeper ignore rule for string-width, which no longer Node 0.10 #634

Merged
merged 1 commit into from Sep 30, 2016

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Sep 26, 2016

I'd like to continue supporting Node 0.10 in the medium term, since this is a widely used utility library.

@maxrimue
Copy link
Member

@bcoe LGTM 👍

When do you think should we stop supporting 0.10? Perhaps the first of January next year would be ideal, that's the time when official support for 0.12 is dropped, and since there's always been more people using 0.10 than 0.12 (since 0.10 was current way longer) it seems reasonable to me to drop support for both there.

I understand that wide support is a great attitude for a utility library, but beyond official support, server operators really have to move on, for security reasons alone, and individuals should've switched by now, as it's usually way easier for them.

@bcoe
Copy link
Member Author

bcoe commented Sep 30, 2016

@maxrimue this is a great question, one we've been asking quite a bit at npm. @seldo recently crunched some numbers and I believe saw that 8.5% of npm users are still on Node 0.10; I think we should hold off on dropping 0.10 support until this # is a bit lower; maybe set a goal like 2% or 3%?

@bcoe bcoe merged commit 16923fe into master Sep 30, 2016
@bcoe bcoe deleted the string-width-ignore branch September 30, 2016 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants