Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to display multiple prefixes #72

Closed
jonthesquirrel opened this issue Feb 12, 2016 · 12 comments
Closed

Option to display multiple prefixes #72

jonthesquirrel opened this issue Feb 12, 2016 · 12 comments
Assignees

Comments

@jonthesquirrel
Copy link

Can an option be added to show all the user's prefixes? if a player has multiple ranks at once on the server, it currently only shows the prefix on the forum from their most recently added rank.

@yariplus
Copy link
Owner

Working on it.

@yariplus yariplus self-assigned this Feb 15, 2016
@yariplus
Copy link
Owner

Just need to do a bit more testing. Which chat and permissions plugin are you using to display the prefixes?

@yariplus
Copy link
Owner

Displays as

PrimaryGroupPrefix SecondaryGroupPrefix ..OtherGroupPrefixes.. PlayerPrefix

I'll add additional display options later, let me know if you have any preferences.

Or if this doesn't work for you lmk, I've only tested it with PEX.

@yariplus
Copy link
Owner

Opps, derpped and left in some testing code.

Use this release.
https://github.com/yariplus/bukkit-plugin-nodebb-integration/releases/tag/v0.7.0-beta.3

@jonthesquirrel
Copy link
Author

Ok, I'm using PEX and MultiPrefix. On the forum it sometimes shows a double prefix. (if it helps, MultiPrefix adds a variable called group_prefix for use in chat formatting)
screen shot 2016-02-18 at 3 05 43 am
screen shot 2016-02-18 at 3 02 30 am
Also note that the prefixes other than the first one don't have the gray shadow behind the letters, so they're not as easy to read.

@yariplus
Copy link
Owner

Fixed the bad shadowing.

I setup MultiPrefix, I'm not getting that strange double prefix though.

@yariplus
Copy link
Owner

Hmm, could be that vault is grabbing the player's primary group prefix if a player prefix doesn't exist.

I'll add a containsValue check, that should fix it.

@yariplus
Copy link
Owner

bfc7a15

@yariplus
Copy link
Owner

Should be fixed now.

Note, it doesn't proactively update the prefix, the player has to sign onto the server first.

@jonthesquirrel
Copy link
Author

Awesome, it does work now. :) Although I've noticed the prefix changes don't seem to take effect until I restart nodebb. Should we open another issue for that?

@yariplus
Copy link
Owner

It should only require the player to sign onto the minecraft server and do a browser refresh.

Yeah, open a new issue if it doesn't work after that.

@jonthesquirrel
Copy link
Author

Confirmed, it updates instantly when a player signs onto the minecraft server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants