Allows requiring PnP files from the outside #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
changed the title
arcanis
force-pushed
the
mael/external-absolute
branch
from
c49fc03
to
528fdb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
External files weren't able to require internal files, even when they were using absolute paths. This was because they never even entered the PnP resolution (since the hook detected that they belonged to a different "tree"), and the native resolution cannot access files within zip archives (nodejs/node#33423).
Closes (?) #1000
How did you fix it?
We now try to detect absolute and relative imports and, if they are, we add them to their own pool of resolution parents if they're covered by a PnP API.
Checklist