Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pnp)!: remove fallbacks to react-scripts and gatsby #3004

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Jun 8, 2021

What's the problem this PR addresses?

The PnP API has a compatibility feature that allows dependencies to access the dependencies of react-scripts and gatsby but these fallbacks cause hard to debug issues and hides undeclared dependencies.

How did you fix it?

Removed the fallbacks

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz requested a review from arcanis as a code owner June 8, 2021 18:02
@merceyz merceyz marked this pull request as draft June 8, 2021 18:07
@merceyz merceyz force-pushed the merceyz/chore/compat-fallback branch 3 times, most recently from 7883c19 to f186186 Compare June 8, 2021 18:45
@merceyz merceyz force-pushed the merceyz/chore/compat-fallback branch from f186186 to 4e4a0aa Compare August 28, 2021 10:05
@merceyz merceyz force-pushed the merceyz/chore/compat-fallback branch 3 times, most recently from d428d48 to 16b046a Compare September 12, 2021 22:20
@merceyz merceyz added the major label Sep 12, 2021
@merceyz merceyz force-pushed the merceyz/chore/compat-fallback branch from 16b046a to 5b50c2f Compare November 25, 2021 15:36
@merceyz merceyz force-pushed the merceyz/chore/compat-fallback branch from 5b50c2f to 6fc471a Compare January 5, 2022 12:23
@merceyz merceyz force-pushed the merceyz/chore/compat-fallback branch from 6fc471a to 5ac7808 Compare January 24, 2022 15:19
@merceyz merceyz force-pushed the merceyz/chore/compat-fallback branch from 5ac7808 to 42c39c7 Compare March 13, 2022 19:05
@merceyz merceyz force-pushed the merceyz/chore/compat-fallback branch from 42c39c7 to a7fd51a Compare March 30, 2022 08:48
@merceyz merceyz force-pushed the merceyz/chore/compat-fallback branch 2 times, most recently from 59e173d to 7b68072 Compare April 2, 2022 13:02
@merceyz merceyz force-pushed the merceyz/chore/compat-fallback branch from 7b68072 to 77fa3d2 Compare April 26, 2022 20:14
@merceyz merceyz force-pushed the merceyz/chore/compat-fallback branch from 77fa3d2 to 406aca9 Compare July 10, 2022 11:03
@merceyz merceyz force-pushed the merceyz/chore/compat-fallback branch from 406aca9 to 6a2e17d Compare July 25, 2022 13:15
@merceyz merceyz force-pushed the merceyz/chore/compat-fallback branch from 5c410a9 to ccc99ee Compare August 8, 2022 01:00
@merceyz merceyz force-pushed the merceyz/chore/compat-fallback branch from ccc99ee to f50870a Compare September 2, 2022 17:02
@merceyz merceyz force-pushed the merceyz/chore/compat-fallback branch from f50870a to 2e977e3 Compare September 28, 2022 15:39
@merceyz merceyz force-pushed the merceyz/chore/compat-fallback branch from 2e977e3 to e75dbb2 Compare October 30, 2022 12:44
@merceyz merceyz force-pushed the merceyz/chore/compat-fallback branch from e75dbb2 to f48e7c9 Compare November 27, 2022 12:54
@merceyz merceyz force-pushed the merceyz/chore/compat-fallback branch from f48e7c9 to 3338a0a Compare December 12, 2022 18:07
@merceyz merceyz force-pushed the merceyz/chore/compat-fallback branch from 3338a0a to 3653c84 Compare June 18, 2023 19:43
@merceyz merceyz force-pushed the merceyz/chore/compat-fallback branch from 3653c84 to dea6cc7 Compare November 4, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant