Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves from ts-node to babel-register, fixes the local sdk #332

Merged
merged 2 commits into from
Aug 4, 2019
Merged

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented Aug 3, 2019

This diff does two things:

  • First, we move from ts-node to babel-register for running our TS files. We don't need to typecheck them since they'll be typechecked later as part of tsc, and Babel is a generally mature tool that we already use for the Jest integration.

  • Second, the local sdk now instantiates babel-register before instantiating PnPify. This allows us to run PnPify directly from its sources, without having to build it beforehand or to use an outdated build (as it would be the case if we were using a version from npm, for example).

  • As an implementation detail, I've abstracted the TypeScript setup inside @berry/monorepo, so all packages can now use setup-ts-execution if needed.

Note that this diff will make our own sdk code slightly different from the one used by our consumers, since we'll need to setup babel-register before. This means that we won't be able to update it just by running yarn pnpify --sdk; we'll have to make the changes manually (or reapply the custom parts after each update).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant