Updates the hash to be 10 characters #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arcanis Provided we won't have too many virtuals for the same package with the same version the math looks good to me, e.g. not much more then 47 virtuals per a package |
|
Awesome, thanks for confirming 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the following probability table, 10 hexadecimal characters give us a probability of 10−9 to have an hash collision for 47 elements.
Given that the hashes are prefixed with the package names and the protocol used, it would require to have a lot of instances of a single package to risk finding a collision, so 10 characters should be fairly safe.
cc @Vlasenko