Prevents infinite loops with --cwd #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
force-pushed
the
mael/infinite-cwd-loops
branch
from
5c07157
to
5e02e5c
Compare
arcanis
force-pushed
the
mael/infinite-cwd-loops
branch
from
5e02e5c
to
cb1d3f3
Compare
3 tasks
arcanis
added a commit
that referenced
this pull request
Jul 28, 2023
**What's the problem this PR addresses?** <!-- Describe the rationale of your PR. --> <!-- Link all issues that it closes. (Closes/Resolves #xxxx.) --> The `--cwd` argument is currently resolved using `realpathSync`. This behavior was introduced in #373 as a workaround for a bug caused by symlinks and the recursive `--cwd` logic. **How did you fix it?** <!-- A detailed description of your implementation. --> Removed the unnecessary `realpath` calls. They are no longer needed due to the removal of the recursive logic in #5600. I've also added a few tests, I'll add the rest from #5595 in a future PR. **Checklist** <!--- Don't worry if you miss something, chores are automatically tested. --> <!--- This checklist exists to help you remember doing the chores when you submit a PR. --> <!--- Put an `x` in all the boxes that apply. --> - [X] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). <!-- See https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released for more details. --> <!-- Check with `yarn version check` and fix with `yarn version check -i` --> - [X] I have set the packages that need to be released for my changes to be effective. <!-- The "Testing chores" workflow validates that your PR follows our guidelines. --> <!-- If it doesn't pass, click on it to see details as to what your PR might be missing. --> - [X] I will check that all automated PR checks pass before the PR gets reviewed. --------- Co-authored-by: Maël Nison <nison.mael@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Yarn was running in an infinite loop when the
--cwdoption was pointing to the/tmpfolder on OSX, which is a symlink to/private/tmp. I'm not 100% sure why it was doing that as we were doing achdirto/tmp, not/private/tmp, so I'd have expectedprocess.cwd()to return the same path, but it's not what happens (reproduced in the Node repl).How did you fix it?
We'll now compare the realpath'd cwds rather than the virtual ones. This isn't a big deal anyway as this will only affect the few commands that use
--cwd.Which packages would need a new release (if any)?
berry-cli
Have you run
yarn version [major|minor|patch] --deferredin those packages?