Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pack): Include changelog #387

Merged
merged 3 commits into from
Aug 23, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Aug 23, 2019

What's the problem this PR addresses?

changelog not being included in tarballs

How did you fix it?

added changelog to always included patterns

**Which packages would need a new release (if

  • @berry/plugin-pack

Have you run yarn version prerelease in those packages?

  • Yes

Follow-up to #385. It doesn't match all the files that are technically included in npm pack but at least the ones that are documented

These changes are more geared towards classic package managers that still use node_modules or 3rd party tools that analyze contents of the tarballs. These files are usually not visible in projects using PnP.

@eps1lon eps1lon changed the title Feat/pack/include changelog feat(pack): Include changelog Aug 23, 2019
@arcanis
Copy link
Member

arcanis commented Aug 23, 2019

Sounds reasonable!

Quick note: it's not a big deal since I know berry/cli is scheduled for bump anyway, but in theory you should also run a version in in it, since it depends on plugin-pack which is scheduled for a bump. To help you you can use yarn version check which will tell you which packages need to declare a bump (or no bump) - I'll soon add it to the chore CI 🙂

@arcanis arcanis merged commit bdf4d2a into yarnpkg:master Aug 23, 2019
@eps1lon eps1lon deleted the feat/pack/include-changelog branch August 23, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants