Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: yarn v1 downloading empty cli #401

Merged
merged 1 commit into from
Aug 26, 2019
Merged

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Aug 26, 2019

What's the problem this PR addresses?

yarn policies set-version v2 creates a file with the content false since https://github.com/yarnpkg/berry/raw/master/packages/berry-cli/bin/berry.js returns 404. Issue was caused by #395

How did you fix it?

Create a symlink from the old cli file to the current location

Which packages would need a new release (if any)?

If any then the v1 cli should get a patch. Though this approach has the benefit that it is immediate and backports the fix.

Have you run yarn version prerelease in those packages?

  • [ ] Yes

@eps1lon
Copy link
Member Author

eps1lon commented Aug 26, 2019

Additional note: The v1 cli should throw if the download returned no success status code.

@arcanis arcanis merged commit b565d36 into yarnpkg:master Aug 26, 2019
@eps1lon eps1lon deleted the fix/binary-empty branch August 26, 2019 16:51
@eps1lon
Copy link
Member Author

eps1lon commented Aug 26, 2019

@arcanis Sorry just tried but github doesn't follow symlinks. You just get ../../yarnpkg-cli/bin/yarn.js.

Upside: Error is thrown instead of yarn nooping.

@arcanis
Copy link
Member

arcanis commented Aug 26, 2019

@eps1lon should be fixed (use berry instead of v2 though).

@eps1lon
Copy link
Member Author

eps1lon commented Aug 26, 2019

@eps1lon should be fixed (use berry instead of v2 though).

Should we change https://yarnpkg.github.io/berry/getting-started/install ?

@arcanis
Copy link
Member

arcanis commented Aug 26, 2019

Yep, that sounds like a good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants