Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(audit)!: remove fallback to publish registries #4639

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

paul-soporan
Copy link
Member

What's the problem this PR addresses?

4.x TODO item: removing the fallback to the publish registries inside yarn npm audit.

See #3583 (comment) for the original discussion.

How did you fix it?

Removed the fallback and removed the manifest parameter of npmConfigUtils.getAuditRegistry since it isn't needed (consistent with npmConfigUtils.getDefaultRegistry).

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@paul-soporan paul-soporan merged commit 6a268d7 into master Jul 19, 2022
@paul-soporan paul-soporan deleted the paul/fix/audit/fallback branch July 19, 2022 23:31
@arcanis arcanis mentioned this pull request Sep 7, 2022
1 task
@merceyz merceyz added this to the 4.0.0 milestone May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants