Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove FetchOptions.skipIntegrityCheck #4641

Merged
merged 4 commits into from
Jul 20, 2022

Conversation

paul-soporan
Copy link
Member

What's the problem this PR addresses?

4.x TODO item: This PR removes FetchOptions.skipIntegrityCheck which got reintroduced in #3612 to avoid a breaking change introduced in #3575.

How did you fix it?

Removed it.

There is still another remaining part of that PR that could be reverted: the merging of the third and fourth argument options bag. I'll open another PR for it since it could use some bikeshedding.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

merceyz
merceyz previously approved these changes Jul 19, 2022
@arcanis arcanis merged commit 985bed2 into master Jul 20, 2022
@arcanis arcanis deleted the paul/refactor/cleanup-3612 branch July 20, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants