Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdks): support Prettier v3 #5411

merged 2 commits into from Jun 25, 2023

fix(sdks): support Prettier v3 #5411

merged 2 commits into from Jun 25, 2023


Copy link

@merceyz merceyz commented Apr 25, 2023

What's the problem this PR addresses?

Prettier v3 changes the path to the entry point so we need to update the path used.

How did you fix it?

Updated the SDK to require prettier and let Node.js find the entry point.


  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz marked this pull request as draft April 26, 2023 14:06
@merceyz merceyz marked this pull request as ready for review April 26, 2023 14:09
Copy link
Member Author

merceyz commented Apr 26, 2023

Prettier v3 uses dynamic imports so people will need to unplug prettier since we don't have a way to add a loader to the existing process.

Depending on how prettier/prettier-vscode#2947 (comment) is solved we might be able to do something.

Copy link

arcanis commented Apr 28, 2023

since we don't have a way to add a loader to the existing process.

There's a registerLoader function being developed:

@merceyz merceyz force-pushed the merceyz/fix/prettier-v3-sdk branch from 96b4b1c to 575089b Compare June 24, 2023 15:48
@merceyz merceyz requested a review from arcanis June 24, 2023 15:48
@arcanis arcanis merged commit 4e6f983 into master Jun 25, 2023
17 checks passed
@arcanis arcanis deleted the merceyz/fix/prettier-v3-sdk branch June 25, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants