test: use esbuild to transpile files #5581
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 15, 2023
arcanis
pushed a commit
that referenced
this pull request
Jul 18, 2023
**What's the problem this PR addresses?** While working on #5581 I noticed that we're not normalizing the registry passed to the `npmHttpUtils` methods. There are tests that are supposed to catch this but the mock wasn't reset before each test so they didn't. **How did you fix it?** Normalize the registry and update the tests to use `wrapNetworkRequest`. **Checklist** - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). - [x] I have set the packages that need to be released for my changes to be effective. - [x] I will check that all automated PR checks pass before the PR gets reviewed.
arcanis
pushed a commit
that referenced
this pull request
Jul 18, 2023
**What's the problem this PR addresses?** One of our tests mocks `got` to validate that it is passed the correct URL which doesn't work when transpiled by esbuild. We have a test that checks that the URL is correct using `wrapNetworkRequest` and various integration tests that should cover it. Extracted from #5581 **How did you fix it?** Removed the test that required mocking `got`. **Checklist** - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). - [x] I have set the packages that need to be released for my changes to be effective. - [x] I will check that all automated PR checks pass before the PR gets reviewed.
merceyz
force-pushed
the
merceyz/chore/esbuild-jest
branch
from
bde16f0
to
780564b
Compare
merceyz
force-pushed
the
merceyz/chore/esbuild-jest
branch
from
780564b
to
8eca89e
Compare
merceyz
changed the title
merceyz
added a commit
that referenced
this pull request
Oct 21, 2023
**What's the problem this PR addresses?** One of our tests mocks `got` to validate that it is passed the correct URL which doesn't work when transpiled by esbuild. We have a test that checks that the URL is correct using `wrapNetworkRequest` and various integration tests that should cover it. Extracted from #5581 **How did you fix it?** Removed the test that required mocking `got`. **Checklist** - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). - [x] I have set the packages that need to be released for my changes to be effective. - [x] I will check that all automated PR checks pass before the PR gets reviewed. (cherry picked from commit 0dc8b6a)
merceyz
force-pushed
the
merceyz/chore/esbuild-jest
branch
from
c67ff88
to
b77df6d
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
We use esbuild to build and run Yarn from sources but not for our test files.
Follow-up to #5180
How did you fix it?
Use esbuild to transpile files in our testing setup.
Checklist