New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Revamp download page #592
Conversation
The build failed:
|
Huh... Do I need to create the page for other languages? The English version ( |
Looking at it now, it works locally, I'm asking a retry of the build with a cleared cache. EDIT: it still fails even if it's a branch on this repository |
I can't build the production version myself, because downloading from crowdin gives me this message:
|
testing around for cause of #592's failure
Not sure what caused it exactly, but a7ba2e4 can be deployed |
<3 |
I'm wondering if those pages should be made manually on crowdin, so that the download works 🤔 |
Yeah, I have no idea. cc @thejameskyle - Do you remember if we have to do anything special when new pages are added? |
Something should be running this script, but it doesn't appear like anything is: Lines 31 to 32 in 43fec17
|
@thejameskyle Does that only run on master? Some of these .md files aren't in master yet, they're just in this PR. |
Oh right... I think we may have never run into this scenario before (where something in crowdin is explicitly depending on something not in crowdin – normally files are totally independent of one another). You might just need to run that script manually. |
When I do $ export CROWDIN_API_KEY=xxx
$ make crowdin-upload
error: Seems Crowdin server API URL is not valid. Please check the `base_url` parameter in the configuration file.
make: *** [crowdin-upload] Error 1
|
I promise I haven't forgotten about this... I'll come back to it and figure out the Crowdin thing. 😛 |
PS. I love treating each Linux distro as an OS in it's own right, with top level native packages. |
Yeah... The "Linux" tab was getting very large, and there's not enough room to add many more tabs. |
Sure but 90% are using Debian/Ubuntu or RHEL/Fedora. Always can do 'other' for users of yggdrasil etc. 😉 |
@Daniel15, I wanted to try out the Crowdin upload script, but there are some conflict in the linux installations that I'm not sure which to keep, could you fix those conflicts? ❤️ |
Sure, I'll try to take a look again soon. |
b67a930
to
8132462
Compare
Deploy preview for yarnpkg ready! Built with commit 8132462 |
Confirmed it's working: https://deploy-preview-592--yarnpkg.netlify.com/en/docs/install I'm going to merge this seeing as it's been sitting around for 8 months with no objections. We can iterate on the design and make it nicer :) |
How did you get it to work in the end @Daniel15? |
Just wanted to say I really like the new design - it goes straight to the best way to deploy packages for your OS. Well done! |
The "Linux" tab was getting a bit unwieldy given there's now several unofficial packages alongside our official Debian and RPM packages. It seems like tabs are the wrong UI element for this page now that it has grown, so I've replaced the tabs with a dropdown list:
This was inspired by the Let's Encrypt / EFF Certbot site (https://certbot.eff.org/), which has a similar dropdown. Design input would be appreciated.
In addition, I've added instructions for installing the RC and nightly releases. Currently, installation of RCs is undocumented, and nightly releases have their own separate page at https://yarnpkg.com/en/docs/nightly.
For RC and nightly releases, the instructions are slightly different. To handle this, I wrapped the version-specific instructions in DIVs with particular classes (
install-only-stable
for stable instructions,install-only-rc
for RCs, andinstall-only-nightly
for nightlies) and show the right one depending on the selection.Test plan
Go to http://localhost:4000/lang/en/docs/install/, it defaults to your current OS
Go to http://localhost:4000/lang/en/docs/install/#asdasdasdasd (invalid OS in URL), it defaults to your current OS
Go to http://localhost:4000/lang/en/docs/install/#debian (OS but no version in URL), it shows Debian instructions
Go to http://localhost:4000/lang/en/docs/install/#debian-rc (OS and version in URL), it shows Debian RC instructions
Switch OS in dropdown, verify that correct instructions are shown
Switch version in dropdown, verify correct instructions are shown