added test for #2744 (#2791)

* added test for #2744

* fix lint

* updated network caches

* more tests optimization

__tests__/commands/add.js

@@ -34,10 +34,6 @@ const runAdd = buildRun.bind(
   },
 );
 
-test.concurrent('install with arg that has install scripts', (): Promise<void> => {
-  return runAdd(['flow-bin'], {}, 'install-with-arg-and-install-scripts');
-});
-
 test.concurrent('install with arg', (): Promise<void> => {
   return runAdd(['is-online'], {}, 'install-with-arg');
 });

__tests__/commands/install/integration-deduping.js

@@ -6,7 +6,7 @@ import * as fs from '../../../src/util/fs.js';
 const assert = require('assert');
 const path = require('path');
 
-jasmine.DEFAULT_TIMEOUT_INTERVAL = 120000;
+jasmine.DEFAULT_TIMEOUT_INTERVAL = 150000;
 
 test.concurrent('install should dedupe dependencies avoiding conflicts 0', (): Promise<void> => {
   // A@2.0.1 -> B@2.0.0

__tests__/commands/install/integration.js

@@ -9,7 +9,7 @@ import * as fs from '../../../src/util/fs.js';
 import {getPackageVersion, explodeLockfile, runInstall, createLockfile} from '../_helpers.js';
 import {promisify} from '../../../src/util/promise';
 
-jasmine.DEFAULT_TIMEOUT_INTERVAL = 90000;
+jasmine.DEFAULT_TIMEOUT_INTERVAL = 150000;
 
 const request = require('request');
 const assert = require('assert');
@@ -139,11 +139,11 @@ test.concurrent('hoisting should factor ignored dependencies', async () => {
 test.concurrent('--production flag ignores dev dependencies', () => {
   return runInstall({production: true}, 'install-production', async (config) => {
     assert.ok(
-      !await fs.exists(path.join(config.cwd, 'node_modules', 'lodash')),
+      !await fs.exists(path.join(config.cwd, 'node_modules', 'left-pad')),
     );
 
     assert.ok(
-      await fs.exists(path.join(config.cwd, 'node_modules', 'react')),
+      await fs.exists(path.join(config.cwd, 'node_modules', 'is-array')),
     );
   });
 });
@@ -912,3 +912,9 @@ test.concurrent('should skip integrity check and do install when --skip-integrit
 
     });
   });
+
+test.concurrent(
+  'should install if symlink source does not exist',
+  async (): Promise<void> => {
+    await runInstall({}, 'relative-symlinks-work', () => {});
+  });

__tests__/fixtures/install/install-production/package.json

@@ -1,8 +1,8 @@
 {
-  "devDependencies": {
-    "lodash": "^4.16.4"
-  },
   "dependencies": {
-    "react": "^15.4.1"
+    "is-array": "^1.0.1"
+  },
+  "devDependencies": {
+    "left-pad": "^1.1.3"
   }
 }

__tests__/fixtures/install/install-production/yarn.lock

@@ -2,89 +2,10 @@
 # yarn lockfile v1
 
 
-asap@~2.0.3:
-  version "2.0.5"
-  resolved "https://registry.yarnpkg.com/asap/-/asap-2.0.5.tgz#522765b50c3510490e52d7dcfe085ef9ba96958f"
+is-array@^1.0.1:
+  version "1.0.1"
+  resolved "https://registry.yarnpkg.com/is-array/-/is-array-1.0.1.tgz#e9850cc2cc860c3bc0977e84ccf0dd464584279a"
 
-core-js@^1.0.0:
-  version "1.2.7"
-  resolved "https://registry.yarnpkg.com/core-js/-/core-js-1.2.7.tgz#652294c14651db28fa93bd2d5ff2983a4f08c636"
-
-encoding@^0.1.11:
-  version "0.1.12"
-  resolved "https://registry.yarnpkg.com/encoding/-/encoding-0.1.12.tgz#538b66f3ee62cd1ab51ec323829d1f9480c74beb"
-  dependencies:
-    iconv-lite "~0.4.13"
-
-fbjs@^0.8.4:
-  version "0.8.6"
-  resolved "https://registry.yarnpkg.com/fbjs/-/fbjs-0.8.6.tgz#7eb67d6986b2d5007a9b6e92e0e7cb6f75cad290"
-  dependencies:
-    core-js "^1.0.0"
-    isomorphic-fetch "^2.1.1"
-    loose-envify "^1.0.0"
-    object-assign "^4.1.0"
-    promise "^7.1.1"
-    ua-parser-js "^0.7.9"
-
-iconv-lite@~0.4.13:
-  version "0.4.15"
-  resolved "https://registry.yarnpkg.com/iconv-lite/-/iconv-lite-0.4.15.tgz#fe265a218ac6a57cfe854927e9d04c19825eddeb"
-
-is-stream@^1.0.1:
-  version "1.1.0"
-  resolved "https://registry.yarnpkg.com/is-stream/-/is-stream-1.1.0.tgz#12d4a3dd4e68e0b79ceb8dbc84173ae80d91ca44"
-
-isomorphic-fetch@^2.1.1:
-  version "2.2.1"
-  resolved "https://registry.yarnpkg.com/isomorphic-fetch/-/isomorphic-fetch-2.2.1.tgz#611ae1acf14f5e81f729507472819fe9733558a9"
-  dependencies:
-    node-fetch "^1.0.1"
-    whatwg-fetch ">=0.10.0"
-
-js-tokens@^2.0.0:
-  version "2.0.0"
-  resolved "https://registry.yarnpkg.com/js-tokens/-/js-tokens-2.0.0.tgz#79903f5563ee778cc1162e6dcf1a0027c97f9cb5"
-
-lodash@^4.16.4:
-  version "4.17.2"
-  resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.2.tgz#34a3055babe04ce42467b607d700072c7ff6bf42"
-
-loose-envify@^1.0.0, loose-envify@^1.1.0:
-  version "1.3.0"
-  resolved "https://registry.yarnpkg.com/loose-envify/-/loose-envify-1.3.0.tgz#6b26248c42f6d4fa4b0d8542f78edfcde35642a8"
-  dependencies:
-    js-tokens "^2.0.0"
-
-node-fetch@^1.0.1:
-  version "1.6.3"
-  resolved "https://registry.yarnpkg.com/node-fetch/-/node-fetch-1.6.3.tgz#dc234edd6489982d58e8f0db4f695029abcd8c04"
-  dependencies:
-    encoding "^0.1.11"
-    is-stream "^1.0.1"
-
-object-assign@^4.1.0:
-  version "4.1.0"
-  resolved "https://registry.yarnpkg.com/object-assign/-/object-assign-4.1.0.tgz#7a3b3d0e98063d43f4c03f2e8ae6cd51a86883a0"
-
-promise@^7.1.1:
-  version "7.1.1"
-  resolved "https://registry.yarnpkg.com/promise/-/promise-7.1.1.tgz#489654c692616b8aa55b0724fa809bb7db49c5bf"
-  dependencies:
-    asap "~2.0.3"
-
-react@^15.4.1:
-  version "15.4.1"
-  resolved "https://registry.yarnpkg.com/react/-/react-15.4.1.tgz#498e918602677a3983cd0fd206dfe700389a0dd6"
-  dependencies:
-    fbjs "^0.8.4"
-    loose-envify "^1.1.0"
-    object-assign "^4.1.0"
-
-ua-parser-js@^0.7.9:
-  version "0.7.12"
-  resolved "https://registry.yarnpkg.com/ua-parser-js/-/ua-parser-js-0.7.12.tgz#04c81a99bdd5dc52263ea29d24c6bf8d4818a4bb"
-
-whatwg-fetch@>=0.10.0:
-  version "2.0.1"
-  resolved "https://registry.yarnpkg.com/whatwg-fetch/-/whatwg-fetch-2.0.1.tgz#078b9461bbe91cea73cbce8bb122a05f9e92b772"
+left-pad@^1.1.3:
+  version "1.1.3"
+  resolved "https://registry.yarnpkg.com/left-pad/-/left-pad-1.1.3.tgz#612f61c033f3a9e08e939f1caebeea41b6f3199a"

__tests__/fixtures/install/relative-symlinks-work/package.json

@@ -0,0 +1,5 @@
+{
+  "dependencies": {
+    "ref": "https://github.com/icenium/ref/tarball/v1.3.2.3"
+  }
+}

__tests__/fixtures/install/relative-symlinks-work/yarn.lock

@@ -0,0 +1,34 @@
+# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
+# yarn lockfile v1
+
+
+bindings@1:
+  version "1.2.1"
+  resolved "https://registry.yarnpkg.com/bindings/-/bindings-1.2.1.tgz#14ad6113812d2d37d72e67b4cacb4bb726505f11"
+
+debug@2:
+  version "2.6.1"
+  resolved "https://registry.yarnpkg.com/debug/-/debug-2.6.1.tgz#79855090ba2c4e3115cc7d8769491d58f0491351"
+  dependencies:
+    ms "0.7.2"
+
+ms@0.7.2:
+  version "0.7.2"
+  resolved "https://registry.yarnpkg.com/ms/-/ms-0.7.2.tgz#ae25cf2512b3885a1d95d7f037868d8431124765"
+
+nan@2:
+  version "2.5.1"
+  resolved "https://registry.yarnpkg.com/nan/-/nan-2.5.1.tgz#d5b01691253326a97a2bbee9e61c55d8d60351e2"
+
+"prebuilt@https://github.com/tailsu/node-prebuilt/tarball/master":
+  version "0.1.0"
+  resolved "https://github.com/tailsu/node-prebuilt/tarball/master#be63229eaccee9c55bb67bc87eac527bdd640aa7"
+
+"ref@https://github.com/icenium/ref/tarball/v1.3.2.3":
+  version "1.3.2"
+  resolved "https://github.com/icenium/ref/tarball/v1.3.2.3#a38db0780c37c66453f3f096dc3ade802cc8ce77"
+  dependencies:
+    bindings "1"
+    debug "2"
+    nan "2"
+    prebuilt "https://github.com/tailsu/node-prebuilt/tarball/master"

__tests__/fixtures/request-cache/GET/github.com/sindresorhus/beeper/archive/master.tar.gz.bin

@@ -1,26 +1,26 @@
 HTTP/1.1 302 Found
 Server: GitHub.com
-Date: Sun, 25 Dec 2016 02:03:39 GMT
+Date: Mon, 27 Feb 2017 15:47:25 GMT
 Content-Type: text/html; charset=utf-8
 Transfer-Encoding: chunked
 Status: 302 Found
 Cache-Control: no-cache
 Vary: X-PJAX
 Location: https://codeload.github.com/sindresorhus/beeper/tar.gz/master
 X-UA-Compatible: IE=Edge,chrome=1
-Set-Cookie: logged_in=no; domain=.github.com; path=/; expires=Thu, 25 Dec 2036 02:03:39 -0000; secure; HttpOnly
-Set-Cookie: _gh_sess=eyJzZXNzaW9uX2lkIjoiOTYyMmVmNzM2NWRkMTM2OWM4NDAxNjJkNzk5MzBhNDAiLCJzcHlfcmVwbyI6InNpbmRyZXNvcmh1cy9iZWVwZXIiLCJzcHlfcmVwb19hdCI6MTQ4MjYzMTQxOX0%3D--a0829cda912ee673fc9b4bcd70471cebb01468e6; path=/; secure; HttpOnly
-X-Request-Id: 4445d1a52c55f6f4e7eab23cd2688a67
-X-Runtime: 0.015626
-Content-Security-Policy: default-src 'none'; base-uri 'self'; block-all-mixed-content; child-src render.githubusercontent.com; connect-src 'self' uploads.github.com status.github.com collector.githubapp.com api.github.com www.google-analytics.com github-cloud.s3.amazonaws.com wss://live.github.com; font-src assets-cdn.github.com; form-action 'self' github.com gist.github.com; frame-ancestors 'none'; frame-src render.githubusercontent.com; img-src 'self' data: assets-cdn.github.com identicons.github.com collector.githubapp.com github-cloud.s3.amazonaws.com *.githubusercontent.com; media-src 'none'; script-src assets-cdn.github.com; style-src 'unsafe-inline' assets-cdn.github.com
+Set-Cookie: logged_in=no; domain=.github.com; path=/; expires=Fri, 27 Feb 2037 15:47:25 -0000; secure; HttpOnly
+Set-Cookie: _gh_sess=eyJzZXNzaW9uX2lkIjoiNTQ5ZmY2NjhhYjBhNmUzNjBlMzcxODkwYjNmOWU1ZDQiLCJzcHlfcmVwbyI6InNpbmRyZXNvcmh1cy9iZWVwZXIiLCJzcHlfcmVwb19hdCI6MTQ4ODIxMDQ0NX0%3D--9b0bef99012199594ed328b8217a51954d26ad04; path=/; secure; HttpOnly
+X-Request-Id: 22459b33994ff5dcc77e62d152494774
+X-Runtime: 0.033042
+Content-Security-Policy: default-src 'none'; base-uri 'self'; block-all-mixed-content; child-src render.githubusercontent.com; connect-src 'self' uploads.github.com status.github.com collector.githubapp.com api.github.com www.google-analytics.com github-cloud.s3.amazonaws.com wss://live.github.com; font-src assets-cdn.github.com; form-action 'self' github.com gist.github.com; frame-ancestors 'none'; img-src 'self' data: assets-cdn.github.com identicons.github.com collector.githubapp.com github-cloud.s3.amazonaws.com *.githubusercontent.com; media-src 'none'; script-src assets-cdn.github.com; style-src 'unsafe-inline' assets-cdn.github.com
 Strict-Transport-Security: max-age=31536000; includeSubdomains; preload
 Public-Key-Pins: max-age=5184000; pin-sha256="WoiWRyIOVNa9ihaBciRSC7XHjliYS9VwUGOIud4PB18="; pin-sha256="RRM1dGqnDFsCJXBTHky16vi1obOlCgFFn/yOhI/y+ho="; pin-sha256="k2v657xBsOVe1PQRwOsHsw3bsGT2VzIqz5K+59sNQws="; pin-sha256="K87oWBWM9UZfyddvDfoxL+8lpNyoUB2ptGtn0fv6G2Q="; pin-sha256="IQBnNBEiFuhj+8x6X8XLgh01V9Ic5/V3IRQLNFFc7v4="; pin-sha256="iie1VXtL7HzAMF+/PVPR9xzT80kQxdZeJ+zduCB3uj0="; pin-sha256="LvRiGEjRqfzurezaWuj8Wie2gyHMrW5Q06LspMnox7A="; includeSubDomains
 X-Content-Type-Options: nosniff
 X-Frame-Options: deny
 X-XSS-Protection: 1; mode=block
 Vary: Accept-Encoding
-X-Served-By: b437fa0c9608399c74bf50b5c3f52799
-X-GitHub-Request-Id: D569B762:557C:10ECE721:585F28FB
+X-Served-By: 9835a984a05caa405eb61faaa1546741
+X-GitHub-Request-Id: 5373:7535:31121A6:4F1F915:58B44A0D
 
 7f
 <html><body>You are being <a href="https://codeload.github.com/sindresorhus/beeper/tar.gz/master">redirected</a>.</body></html>