Skip to content

Commit

Permalink
reverted Nested executables #1210 to fix #1823 (#1867)
Browse files Browse the repository at this point in the history
  • Loading branch information
bestander committed Nov 15, 2016
1 parent 1b2f6b5 commit 5a59acb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion __tests__/commands/install.js
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,8 @@ test.concurrent(
},
);

test.concurrent('install should hoist nested bin scripts', (): Promise<void> => {
// disabled to resolve https://github.com/yarnpkg/yarn/pull/1210
test.skip('install should hoist nested bin scripts', (): Promise<void> => {
return runInstall({binLinks: true}, 'install-nested-bin', async (config) => {
const binScripts = await fs.walk(path.join(config.cwd, 'node_modules', '.bin'));
// need to double the amount as windows makes 2 entries for each dependency
Expand Down
2 changes: 1 addition & 1 deletion src/package-linker.js
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ export default class PackageLinker {
if (this.config.binLinks) {
const tickBin = this.reporter.progress(flatTree.length);
await promise.queue(flatTree, async ([dest, {pkg}]) => {
const binLoc = path.join(this.config.cwd, this.config.getFolder(pkg));
const binLoc = path.join(dest, this.config.getFolder(pkg));
await this.linkBinDependencies(pkg, binLoc);
tickBin(dest);
}, 4);
Expand Down

0 comments on commit 5a59acb

Please sign in to comment.