Skip to content

Commit

Permalink
Do not exit 1 if yarn already installed (#829)
Browse files Browse the repository at this point in the history
I think it's bad idea to exit 1 in this case - because this script can't be used in pipeline or in ansible. Throwing exception breaks next movements. If Yarn already installed this script - it will warn and normally exited with exit code 0.
What do you think?
  • Loading branch information
PlugIN73 authored and Sebastian McKenzie committed Oct 14, 2016
1 parent f12ea64 commit ae0caa3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/install-latest.sh
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ yarn_install() {
if [ -d "$HOME/.yarn" ]; then
printf "$red> ~/.yarn already exists, possibly from a past Yarn install.$reset\n"
printf "$red> Remove it (rm -rf ~/.yarn) and run this script again.$reset\n"
exit 1
exit 0
fi

yarn_get_tarball
Expand Down

0 comments on commit ae0caa3

Please sign in to comment.